Repository navigation
refactor(cms): map Bootstrap warning to admonition warning class - #1247
Merged
Merged
Conversation
Revert workaround that targeted caution after Core-Styles fixes caution vs warning styling. Co-authored-by: Cursor <cursoragent@cursor.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
wesleyboar
changed the title
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Oct 7, 2026
## Overview Swaps admonition `caution` and `warning` styling and demo use-case copy so severity matches typical interpretation. > [!CAUTION] > **Must update all clients, because this is a breaking change** and I don't want to bump major version. ## Related required by: - TACC/mkdocs-tacc#43 - TACC/Core-CMS#1247 - TACC/TACC-Docs#179 - DesignSafe-CI/DS-User-Guide#293 ## Changes - **fixed** `admonition` caution vs warning message-type mapping and icon - **updated** admonition demo `config.yml` use cases - **updated** `dist` build output ## Testing 1. `make start` (or ensure Fractality is on port 3000 with this branch checked out). 2. Open http://127.0.0.1:3000/components/detail/admonition 3. Confirm **Caution** is red (error) and **Warning** is yellow (warning). ## UI | Before | After | | - | - | | <img width="760" alt="Admonition caution and warning (before)" src="https://github.com/user-attachments/assets/16e4cc0f-29df-4cb1-b99f-019deb39c14e" /> | <img width="760" alt="Admonition caution and warning (after)" src="https://github.com/user-attachments/assets/775f0a19-e328-4cf8-9def-d824efa3eb29" /> | Co-authored-by: Cursor <cursoragent@cursor.com>
Align with minor release after admonition fix; refresh package-lock after v2.59.0 publishes. Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Oct 7, 2026
## Overview Forces release-please to propose **2.59.0** (minor) instead of **3.0.0** after `fix(components)!` on #758. > [!IMPORTANT] > **Why?** [v3 is a whole project.](https://github.com/orgs/TACC/projects/10) I will update clients to not break by immediately integrating this breaking change for them. ## Related - blocks merge of #759 until this is on `main` - required by TACC/mkdocs-tacc#43 - required by TACC/Core-CMS#1247 ## Changes - **added** empty commit with `Release-As: 2.59.0` footer (per PUBLISHING.md) ## Testing 1. Merge this PR to `main`. 2. Confirm release-please updates #759 to `chore(main): release 2.59.0` (not 3.0.0). ## Notes Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reverts temporary mapping because Core-Styles fixed mapping.
Related
requires:
Changes
extend.pyalert context mapping for warningadmonition.cortal-icons.cssyellow alert icon target classpackage-lock.jsonfor@tacc/core-styles2.59.0Testing & UI
Important
No change expected.