Repository navigation
fix(components)!: swap admonition caution and warning severity - #758
Merged
Merged
Conversation
Caution and warning mapped to the wrong message types; align styles and demo copy with intended use. Co-authored-by: Cursor <cursoragent@cursor.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This was referenced Oct 5, 2026
wesleyboar
changed the title
This was referenced Oct 7, 2026
wesleyboar
added a commit
that referenced
this pull request
Oct 7, 2026
## Overview Forces release-please to propose **2.59.0** (minor) instead of **3.0.0** after `fix(components)!` on #758. > [!IMPORTANT] > **Why?** [v3 is a whole project.](https://github.com/orgs/TACC/projects/10) I will update clients to not break by immediately integrating this breaking change for them. ## Related - blocks merge of #759 until this is on `main` - required by TACC/mkdocs-tacc#43 - required by TACC/Core-CMS#1247 ## Changes - **added** empty commit with `Release-As: 2.59.0` footer (per PUBLISHING.md) ## Testing 1. Merge this PR to `main`. 2. Confirm release-please updates #759 to `chore(main): release 2.59.0` (not 3.0.0). ## Notes Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar
added a commit
that referenced
this pull request
Oct 7, 2026
PR Generated by `release-please` --- ## [2.59.0](v2.58.4...v2.59.0) (2026-10-07) ### ⚠ BREAKING CHANGES * **components:** swap admonition caution and warning severity ([#758](#758)) > [!IMPORTANT] > I carefully integrate into all clients to prevent breakage, to avoid v3 release now. ### Bug Fixes * **components:** swap admonition caution and warning severity ([#758](#758)) ([594f24c](594f24c)) ### Miscellaneous Chores * force next release to v2.59.0 (Release-As footer) ([#761](#761)) ([a952537](a952537)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Oct 7, 2026
## Overview Reverts temporary mapping because Core-Styles fixed mapping. ## Related requires: - TACC/Core-Styles#758 ## Changes - **fixed** `extend.py` alert context mapping for warning - **fixed** `admonition.cortal-icons.css` yellow alert icon target class - **updated** `package-lock.json` for `@tacc/core-styles` 2.59.0 ## Testing & UI 1. Have a running CMS instance with this branch. 2. Rebuild CSS. 3. Open http://127.0.0.1:8007/test/test-alert-style/. 4. Compare Admonition **warning** appearance to before. 5. Verify no change. > [!IMPORTANT] > No change expected. | Before | After | | - | - | | <img width="920" alt="Bootstrap vs admonition warning row (before)" src="https://github.com/user-attachments/assets/2206e491-38be-4515-a86a-f5abbaa0b7cd" /> | <img width="920" alt="Bootstrap vs admonition warning row (after)" src="https://github.com/user-attachments/assets/91f6c494-2586-4f95-80f3-6e69d8d6467e" /> | --------- Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar
added a commit
to TACC/mkdocs-tacc
that referenced
this pull request
Oct 7, 2026
## Overview Aligns admonition caution/warning styling with Core-Styles and bumps the theme CDN to **2.59.1**. ## Related requires: - TACC/Core-Styles#758 - https://github.com/TACC/Core-Styles/releases/tag/v2.59.1 required by: - TACC/TACC-Docs#179 - DesignSafe-CI/DS-User-Guide#293 ## Changes - **swapped** `pymdownx.css` caution vs warning icons - **updated** CDN pins for `core-styles.base.css` and `core-styles.docs.css` - **swapped** `extensions.md` caution vs warning usage - **updated** theme version to **1.0.5** ## Testing 1. Start server using this branch. 2. Open `/extensions`. 3. Verify admonitions: **caution** red, **warning** yellow. 4. Verify: no other style changes. ## UI | Before | After | | - | - | | <img width="757" alt="Admonition caution and warning (before)" src="https://github.com/user-attachments/assets/e1d64e90-fc74-4b1b-ab55-d9bd2a736547" /> | <img width="757" alt="Admonition caution and warning (after)" src="https://github.com/user-attachments/assets/133be934-a6e6-4544-8ebc-1e2d2603f0d4" /> | --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Swaps admonition
cautionandwarningstyling and demo use-case copy so severity matches typical interpretation.Caution
Must update all clients, because this is a breaking change and I don't want to bump major version.
Related
required by:
Changes
admonitioncaution vs warning message-type mapping and iconconfig.ymluse casesdistbuild outputTesting
make start(or ensure Fractality is on port 3000 with this branch checked out).UI