Skip to content

fix(docs): swap caution and warning admonitions & theme update - #293

Draft
wesleyboar wants to merge 12 commits into
mainfrom
fix/admonition-caution-warning-swap
Draft

wesleyboar wants to merge 12 commits into
mainfrom
fix/admonition-caution-warning-swap

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Caution

Link color is too light, because —

  • new theme now uses --global-color-accent--light for colors
  • old user-guide/css/tacc/core-styles.docs.css assigns different (brighter) value for --global-color-accent--light

— so adjust link color before merging.

Important

Swaps !!! caution and !!! warning in source text, so red/yellow does not change for user since I swapped the colors in the theme.

What? Why?

Admonitions, i.e. —

!!! caution
    Important text in a box.

— were using yellow for caution and red for warning, because of a mistake long ago. I fixed the mistake upstream. To make sure TACC-Docs does not swap colors, I update !!! caution to use !!! warning, and vice-versa.

Important

Changes link aliases from https://(www.)designsafe-ci.org/user-guide/ to /, so those links are not interpreted as absolute links be improvement to script that identifies external links._

What? Why?

There is a script that identifies external links, then:

  • appends [↗] to them
  • makes them open in a new window

That script now interprets http:// and https:// as external links (because it is simpler, reliable logic) but expects —

  • authors to not use http:// and https:// for links on the same domain

— yet many links to pages on this same docs site are (unnecessarily, and now inappropriately) using http:// and https://.

Note

Accesibility changes:

  • <h1> titles now darker (match body text)
  • hyperlinks now brighter (distinct from text)

Related

requires:

Changes

  • changed admonition types across docs:
    • datadepot resources
    • deleted / redirect pages

Testing

Admonitions

  1. Start server.

  2. Compare —

    — and —

    — severities stay the same

Core-Styles 2.37.4 → 2.59.1

  1. Verify no changes here:

UI

Admonitions

before after
DSUG before DSUG after

@wesleyboar
wesleyboar requested a review from a team October 5, 2026 20:21
@netlify

netlify Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for ds-user-guide ready!

Name Link
🔨 Latest commit 3880a48
🔍 Latest deploy log https://app.netlify.com/projects/ds-user-guide/deploys/6ac7b6063e8be80008e05375
😎 Deploy Preview https://deploy-preview-293--ds-user-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

wesleyboar added a commit to TACC/Core-Styles that referenced this pull request Oct 7, 2026
## Overview

Swaps admonition `caution` and `warning` styling and demo use-case copy
so severity matches typical interpretation.

> [!CAUTION]
> **Must update all clients, because this is a breaking change** and I
don't want to bump major version.

## Related

required by:
- TACC/mkdocs-tacc#43
- TACC/Core-CMS#1247
- TACC/TACC-Docs#179
- DesignSafe-CI/DS-User-Guide#293

## Changes

- **fixed** `admonition` caution vs warning message-type mapping and
icon
- **updated** admonition demo `config.yml` use cases
- **updated** `dist` build output

## Testing

1. `make start` (or ensure Fractality is on port 3000 with this branch
checked out).
2. Open http://127.0.0.1:3000/components/detail/admonition
3. Confirm **Caution** is red (error) and **Warning** is yellow
(warning).

## UI

| Before | After |
| - | - |
| <img width="760" alt="Admonition caution and warning (before)"
src="https://github.com/user-attachments/assets/16e4cc0f-29df-4cb1-b99f-019deb39c14e"
/> | <img width="760" alt="Admonition caution and warning (after)"
src="https://github.com/user-attachments/assets/775f0a19-e328-4cf8-9def-d824efa3eb29"
/> |

Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar added a commit to TACC/mkdocs-tacc that referenced this pull request Oct 7, 2026
## Overview

Aligns admonition caution/warning styling with Core-Styles and bumps the
theme CDN to **2.59.1**.

## Related

requires:
- TACC/Core-Styles#758
- https://github.com/TACC/Core-Styles/releases/tag/v2.59.1

required by:
- TACC/TACC-Docs#179
- DesignSafe-CI/DS-User-Guide#293

## Changes

- **swapped** `pymdownx.css` caution vs warning icons
- **updated** CDN pins for `core-styles.base.css` and
`core-styles.docs.css`
- **swapped** `extensions.md` caution vs warning usage
- **updated** theme version to **1.0.5**

## Testing

1. Start server using this branch.
2. Open `/extensions`.
3. Verify admonitions: **caution** red, **warning** yellow.
4. Verify: no other style changes.

## UI

| Before | After |
| - | - |
| <img width="757" alt="Admonition caution and warning (before)"
src="https://github.com/user-attachments/assets/e1d64e90-fc74-4b1b-ab55-d9bd2a736547"
/> | <img width="757" alt="Admonition caution and warning (after)"
src="https://github.com/user-attachments/assets/133be934-a6e6-4544-8ebc-1e2d2603f0d4"
/> |

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar and others added 3 commits October 7, 2026 17:29
Bump after mkdocs-tacc release with admonition CDN fix; run poetry lock after 1.0.5 publishes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Lock to the published RC with admonition CDN fixes ahead of 1.0.5 stable.

Co-authored-by: Cursor <cursoragent@cursor.com>
Preserve on-screen severity after Core-Styles and mkdocs-tacc correct caution vs warning styling.

Co-authored-by: Cursor <cursoragent@cursor.com>
@wesleyboar
wesleyboar force-pushed the fix/admonition-caution-warning-swap branch from 33658ec to 2353b0b Compare October 7, 2026 23:10
github-actions Bot and others added 9 commits October 7, 2026 23:11
Refresh lock for RC with Core-Styles 2.59.2 heading fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
…I/DS-User-Guide into chore/ci-docker-mkdocs-tacc
Special case: not part of caution/warning swap.

Co-authored-by: Cursor <cursoragent@cursor.com>
Merge theme lock from chore branch into admonition PR.
Co-authored-by: Cursor <cursoragent@cursor.com>
@wesleyboar
wesleyboar marked this pull request as draft October 8, 2026 15:31
@wesleyboar
wesleyboar marked this pull request as ready for review October 8, 2026 15:37
@wesleyboar
wesleyboar marked this pull request as draft October 8, 2026 15:37
@wesleyboar wesleyboar changed the title fix(docs): swap caution and warning admonitions fix(docs): swap caution and warning admonitions & theme update Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant