Repository navigation
fix(schema): find packaged resources beside native test bundles - #75
Conversation
ThorFuchs
left a comment
There was a problem hiding this comment.
Source review of exact head 3050841 found no actionable issue. The added candidate is restricted to the code-owner .xctest parent and appended after existing locations; the current metered root selector, cancellation and exact resource size/SHA checks remain authoritative. No public API, dependency, platform, resource payload or root discovery/cap identity changes. The separate public native test-host regression is meaningful and retains the original distribution failure checks. An independent remote-revision SwiftPM consumer has now resolved this public head and passed with both resource overrides absent. Local exact-tree test counts are recorded in the PR body. Full provider Native/Linux checks remain pending; no merge, release or performance pass is inferred from this review.
Native SwiftPM can run tests through
swiftpm-testing-helper, makingBundle.mainand the command-line executable directory point into the toolchain. JSONSchema's code is in a nested.xctestbundle, while its packaged Draft 2020-12 resources are siblings of that bundle. The previous locations therefore miss present, intact resources and throw an operational.metaSchemaerror.Retain the schema code-owner Bundle and, after every existing candidate, search its parent only when the owner is an
.xctest. Existing resource precedence, the shared compilation meter, finite limits, cancellation, nine exact size/SHA checks and corruption failures remain authoritative. This is a fixed test-host layout correction with no API, product, dependency, platform or version change.Add a separate public Swift Testing consumer to DistributionAcceptance and run it through the existing native CI distribution qualifier in Debug and Release. Both resource overrides are removed from child environments. Require exactly one function, all nine official resources and an exact integer positive/negative pair above 2^53. Preserve the original intact/missing/corrupt executable probes and all root discovery/cap inventories. Regenerate the CLI source digest and document the layout.
Validation on exact head
3050841860dc8f6f28ad38874b143f9a712d0e05:All eight hosted qualification checks passed on this exact head: Native and Linux, both architectures. Full native Debug/Release each ran 975 functions (58 native-lane commands); each Linux architecture ran 959 functions per configuration (54 lane commands), with separate ASan/TSan and composition/reference gates. Native ASan/TSan covered 975/60 functions; Linux covered 959/59. All 1,500 authored public declarations remain documented. A real independent SwiftPM consumer resolved this public revision and passed in Debug and Release without resource overrides. The Git-free archive lane ran all 58 native commands, verified source unchanged and produced the byte-identical 2,162,598-byte candidate archive, SHA-256
9bfff921e1e06cb3df64d2680cd21264b6fd7a2918024a5468a1d094b450d940. No release tag or publication is included. Parallel 1.8 branches and the historical released source remain untouched.