fix: tolerate prose around model JSON - #382
Open
zrh805 wants to merge 1 commit into
Open
Conversation
zrh805
force-pushed
the
codex/tolerant-json-responses
branch
from
August 3, 2026 01:36
c44b302 to
7d5190b
Compare
zrh805
force-pushed
the
codex/tolerant-json-responses
branch
from
August 3, 2026 01:37
7d5190b to
5012e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326.
Model providers sometimes return a valid JSON object or array with explanatory prose before or after it.
extract_jsonpreviously required the entire response to be JSON, so these replies became{}and later stages could fail or silently use fallback values.This change uses
json.JSONDecoder.raw_decodefrom the first JSON delimiter, preserving braces inside JSON strings and supporting both object and array responses. It retains the existing fallback for PythonNonevalues and trailing commas.Tests added for prose-wrapped objects and arrays, fenced JSON with braces in a string, and the legacy repair path.
Validation:
PYTHONPATH=. uv run --with-requirements requirements.txt --with pytest pytest -q(23 passed).