Repository navigation
fix(plugin_source): give up on a git clone that outlasts its timeout - #98
Merged
Merged
Conversation
marcossevilla
previously approved these changes
Oct 21, 2026
marcossevilla
approved these changes
Oct 21, 2026
marcossevilla
approved these changes
Oct 28, 2026
The clone had no timeout, so an unreachable github.com left install and doctor waiting forever. HarnessDetector already bounds its own probe at five seconds. The git process is not killed, but nothing waits on it and the half-filled temp directory is thrown away, so the next run starts clean. GitPluginSource also takes an optional log sink, which carries the command line and git's stderr to --verbose.
marcossevilla
force-pushed
the
fix/clone-timeout
branch
from
October 28, 2026 11:45
a6fe75f to
bf4f931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack 1 of 5 for #68. Base:
main.The clone in
GitPluginSourcehad no timeout, so an unreachable github.com leftinstallanddoctorwaiting forever.HarnessDetectoralready bounds its own probe at five seconds.The git process is not killed, but nothing waits on it and the half-filled temp directory is thrown away, so the next run starts clean. The source also takes an optional log sink, which carries the command line and git's stderr to
--verbose; nothing passes it yet, that comes in stack 2.Type of Change
🤖 Generated with Claude Code