You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rosetta: Translation Teams: Give each locale’s team page its own title and canonical URL - #1257
A locale’s details page, /polyglots/teams/?locale=xx_YY, has the same <title>, canonical URL and og:url as the all-locales overview, so search engines treat every team page as a duplicate of /polyglots/teams/.
This adds the locale’s English name to the document title (“Translation Teams | Indonesian | Translate WordPress”) and keeps the locale query arg in the canonical URL and Jetpack’s og:url. Unknown locales and en_US, which already 404, are left alone.
The wporg-seo plugin lowercases every canonical URL (https://meta.trac.wordpress.org/ticket/4414), which would turn the canonical into ?locale=id_id, and that currently 404s. So the lookup now ignores case: ?locale=id_id shows the Indonesian page too. No two wp_locale values differ only by case.
The clean /teams/<locale>/ URLs the ticket mentions as a nice-to-have are not part of this.
…e and canonical URL
A locale's details page, /polyglots/teams/?locale=xx_YY, shared the title,
canonical URL and og:url of the all-locales page, so search engines folded
every team page into the overview.
Add the locale's English name to the document title and keep the `locale`
query arg in the canonical URL and og:url. Canonical URLs are lowercased
site-wide (#4414), so the locale lookup now ignores case; otherwise the
canonical would point at a 404.
Fixes #4683.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The locale shortcode now uses shared locale lookup helpers. On singular pages containing the shortcode, title, canonical URL, and Jetpack Open Graph filters can apply metadata for a valid non-English locale.
Bootstrap registers title, canonical URL, and Jetpack Open Graph filters. The filters apply locale metadata when the displayed locale and required values are available.
Locale team pages get their own title and canonical URL, and invalid or English locales still return 404. No actionable merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: each locale's team page gets its own title and canonical URL. The raw summary confirms the added filters for document title and canonical URL, which match this. The ti…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: each locale's team page gets its own title and canonical URL. The raw summary confirms the added filters for document title and canonical URL, which match this. The title does not mention the case-insensitive locale lookup or Open Graph tags, but those are secondary details. The title is specific and concise, so it passes.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://meta.trac.wordpress.org/ticket/4683
A locale’s details page,
/polyglots/teams/?locale=xx_YY, has the same<title>, canonical URL andog:urlas the all-locales overview, so search engines treat every team page as a duplicate of/polyglots/teams/.This adds the locale’s English name to the document title (“Translation Teams | Indonesian | Translate WordPress”) and keeps the
localequery arg in the canonical URL and Jetpack’sog:url. Unknown locales anden_US, which already 404, are left alone.The wporg-seo plugin lowercases every canonical URL (https://meta.trac.wordpress.org/ticket/4414), which would turn the canonical into
?locale=id_id, and that currently 404s. So the lookup now ignores case:?locale=id_idshows the Indonesian page too. No twowp_localevalues differ only by case.The clean
/teams/<locale>/URLs the ticket mentions as a nice-to-have are not part of this.Testing
<title>reads “Translation Teams | Indonesian | Translate WordPress”.<link rel="canonical">ishttps://make.wordpress.org/polyglots/teams/?locale=id_id.og:urlishttps://make.wordpress.org/polyglots/teams/?locale=id_ID.og:urlare unchanged.?locale=xx_YY. Both still return a 404 with the unchanged title and canonical.🤖 Generated with Claude Code
Summary by CodeRabbit