Repository navigation
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/utils/signing.py | 95.77% | 93.59% | 🔴 -2.18% |
| Total | 93.10% | 93.08% | 🔴 -0.02% |
Generated by coverage-comment.yml
Iwaniukooo11
requested changes
Oct 14, 2026
| verifier_wrong_key(signed_card) | ||
|
|
||
|
|
||
| def test_verifier_skips_malformed_protected_header( |
Member
There was a problem hiding this comment.
Please extend the test to also cover json.JSONDecodeError, UnicodeDecodeError, and the not isinstance(protected_header, dict) guard
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for each AgentCard signature: + skip malformed base64, UTF-8, or JSON protected headers attempt verification of remaining signaturesThe malformed-header failure now reaches the existing
InvalidSignaturesErrorresult when no signature verifies, while a later valid signature can still verify. Fixes #1332.Evidence
binascii.Errorforprotected='!!!not-base64url!!!'and stopped before later signatures.InvalidSignaturesErrorand malformed-then-valid input verifies../scripts/lint.shpassed;uv run pytest --cov=src --cov-report=term-missingreported 2,270 passed, 183 skipped, 3 xfailed, 1 xpassed, and 93% total coverage.Merge Danger
Door: Two-way
Blast Radius: Low
Only malformed protected-header parsing is skipped; key-provider and signature-verification handling remain unchanged.