Repository navigation
ate-setup can route several credential providers on the agentgateway egress, so your own provider runs beside the bundled one - #2830
Closed
Quentin Bisson (QuentinBisson) wants to merge 1 commit into
Conversation
Bowei Du (bowei)
added
area/dev-infra
area/network
area/security
Quentin Bisson (QuentinBisson)
marked this pull request as ready for review
October 20, 2026 16:28
Quentin Bisson (QuentinBisson)
force-pushed
the
feat/credential-provider-classes
branch
from
October 22, 2026 13:04
d495b66 to
59f86a6
Compare
Contributor
Author
|
Eitan Yarmush (@EItanya) do you think you could review this one if you have some time? |
…ntgateway egress --credential-provider also takes a JSON array of provider objects, one per class. The agentgateway egress renders one credentialProviders entry per provider on both listeners, so a provider deployed outside the repository can be reached beside the bundled k8s.io one. The array refuses an empty list, a repeated name and enabled; the Envoy dataplane, whose injector takes one provider on flags, refuses more than one. Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Quentin Bisson (QuentinBisson)
force-pushed
the
feat/credential-provider-classes
branch
from
October 26, 2026 13:15
59f86a6 to
fdabcb7
Compare
Contributor
Author
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/substrate
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--credential-providernow also takes a JSON array of the existing objects, one per class, each rendered as its owncredentialProvidersentry on both agentgateway listeners, so a provider you deploy runs beside the bundledk8s.ioone instead of replacing it. Repeated names, an empty array andenabledinside the array are refused; the object form is unchanged, and the Envoy dataplane refuses more than one provider since its injector takes one on flags. "For credential provider developers" now describes routing a provider deployed beside Substrate.Fixes #2829