Repository navigation
Delete hack/install-ate.sh and hack/install-ate-kind.sh - #3354
Merged
Julian Gutierrez Oschmann (juli4n) merged 2 commits intoOct 28, 2026
Merged
Julian Gutierrez Oschmann (juli4n) merged 2 commits into
Julian Gutierrez Oschmann (juli4n) merged 2 commits into
Conversation
Collaborator
|
This needs a rebase now. BTW, I noticed this is not tagged for M3. You still plan to merge it? |
Haven Xia (HavenXia)
force-pushed
the
rm-install-ate
branch
from
October 28, 2026 02:24
b475413 to
6dd4602
Compare
Haven Xia (HavenXia)
requested review from
Taahir Ahmed (ahmedtd),
Dmitry Berkovich (dberkov) and
Julian Gutierrez Oschmann (juli4n)
October 28, 2026 02:54
Haven Xia (HavenXia)
marked this pull request as ready for review
October 28, 2026 02:55
Haven Xia (HavenXia)
force-pushed
the
rm-install-ate
branch
2 times, most recently
from
October 28, 2026 03:22
7ff81db to
7876af3
Compare
Signed-off-by: Haven Xia <haoyuxia@google.com>
Haven Xia (HavenXia)
force-pushed
the
rm-install-ate
branch
from
October 28, 2026 16:50
7876af3 to
a5d6596
Compare
Member
Author
Discussed offline we plan to merge it to reduce confusion. Rebased |
Signed-off-by: Haven Xia <haoyuxia@google.com>
Collaborator
|
Nit: Update PR description to match the changes now that we got rid of the |
Benjamin Elder (BenTheElder)
enabled auto-merge
October 28, 2026 21:05
Julian Gutierrez Oschmann (juli4n)
approved these changes
Oct 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2718, both scripts only forward to
go run ./cmd/ate-setup.This PR deletes them, and every caller, CI step and doc now runs
ate-setupdirectly. CI passes--kindin place ofinstall-ate-kind.sh. The kind Quickstart sets the same option once withexport ATE_INSTALL_KIND=true, so the demo READMEs no longer mention kind or GKE.Fix #1503
Breaking Change
There are some behavior changes:
ate-setupexits 1 on an unknown subcommand such asdeploy demo demo-counter, instead of printing help and exiting 0, this fixes ate-setup: parent commands (deploy, deploy demo) silently exit 0 on unknown subcommands (e.g. 'deploy demo-counter') #3209--setup-csino longer accepts the old shell spellingstrue,falseor an empty value because they are returnedunknown CSI driver, the previous params are left for compatiblity with shell script.hack/setup-csi-hostpath-kind.shis replaced byate-setup --kind setup csi hostpath.Testing
Ran every demo README as written on fresh kind and GKE clusters. Every
ate-setupstep works on both. claude-code-multiplex, parking and the counter microVM script still fail, as they did before this PR (#2487, #3287; #2092 rewrites the microVM script).Claude help review the list and do the replacement, I reviewed.