Repository navigation
tools: remove setup-gcp and hack/teardown.sh - #3396
Steven Shriver (stshrive) wants to merge 1 commit into
Conversation
Aditya Shantanu (aditya-shantanu)
left a comment
Aditya Shantanu (aditya-shantanu)
left a comment
There was a problem hiding this comment.
DCO is a required check and fails: the commit author is 6007067+stshrive@users.noreply.github.com but the sign-off is stshrive@google.com. Also, per AGENTS.md, drop the #3390 / #2304 references from the commit message and keep them in the PR description.
Aditya Shantanu (aditya-shantanu)
left a comment
Aditya Shantanu (aditya-shantanu)
left a comment
There was a problem hiding this comment.
Approving now that substrate-gke has --cluster-scoped. The DCO check still needs the sign-off email to match the author email before this can merge.
a2b4efc to
de1988a
Compare
7a1f314 to
4936ec4
Compare
This is now resolved |
|
Cleanup these after this change gets in: #2745 #2532 #1999 I think these are mostly covered by changes in https://github.com/ai-on-gke/substrate-gke already. |
The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match. hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it. Signed-off-by: Steven Shriver <6007067+stshrive@users.noreply.github.com>
4936ec4 to
d10d543
Compare
|
need rebase |
The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match.
Covers #3390, except that hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it.
Part of #2304