Repository navigation
Conversation
akoi
changed the title
Prepare local upload versions with upstream's agvtool step instead of changing application version settings. Keep only the icon compatibility fix in the final diff.
akoi
changed the title
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by PR #2. PR #2 targets
maindirectly and includes this identical icon compatibility fix together with the upstream Statistics daylight-saving fix and tests. Closing this PR without merging to avoid two overlapping changes.Under our local Xcode 27.1 toolchain, the stock universal app-icon catalog omits required iPhone/iPad icon files and emits missing-icon warnings. Remove only the three
scale: "1x"fields from the default, dark and tinted entries; preserve the images and upstream build-number settings.Retain this as a temporary compatibility workaround and reassess it when adopting future LoopFollow or Xcode releases. Further toolchain investigation is deferred; this PR does not establish an Xcode 27.1 regression.
Validation: controlled stock-versus-patched
actoolcompilation reproduced the warnings and absentCFBundleIconFileswith stock metadata, and generated the required files and entries with the patch, including with--include-all-app-icons. The two version configuration files match the main-branch baseline exactly; upstream-styleagvtool new-version -allupdates both bundle versions in an isolated copy. Plist/JSON syntax andgit diff --checkpassed. The already-installed TestFlight build 2 was built from the earlierdf2b19arevision; no replacement app build or upload is included here.