Repository navigation
Backport Statistics DST fix and icon workaround to release - #2
Merged
Merged
Conversation
Prepare local upload versions with upstream's agvtool step instead of changing application version settings. Keep only the icon compatibility fix in the final diff.
Adapt upstream LoopFollow PR loopandlearn#795 to a shared calendar-day helper. Preserves local Xcode 27.1 app icon fix and adds Europe/Stockholm DST tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
LoopFollow 7.1.0 Statistics can freeze when Download Treatments is enabled and the selected period crosses a daylight-saving fall-back day, such as 25 October 2026 in Europe/Stockholm. Both the scheduled-basal gap loop and temporary-basal adjustment loop advanced by a fixed 86,400 seconds, which can land on the same 25-hour calendar day indefinitely.
Backport upstream fix #795 through a shared calendar-day helper and add three regression tests for autumn, spring and a seven-day range crossing autumn. Retain the three icon-metadata removals from superseded PR #1 for local Xcode 27.1 compatibility. The final diff touches five files; icon images, signing identifiers and upstream version configuration are unchanged.
Branch workflow
This PR is
fix/stats-dst-fallback-2026→release. The newreleasebase starts at official upstream v7.1.0,4a74b781ad6836dd77eccc03bb08a42749dd59a6. The fork’smainremains an exact upstream mirror. Keeping the existingfix/*head and changing the base follows the documented t1d-infra policy; this PR does not merge upstreamdevor place local patches onmain.Validation
22040408ea85d67a2a2d8dff5b6f12e9f29a32c8.StatsCalendarDayTestspassed, including a separate targeted run. These ran in the actual iOS app/test target, replacing the earlier isolated Linux-only validation.git diff --checkpass. The icon workaround’s earlier controlledactoolcomparison reproduced the missing renditions with stock metadata and verified generation after removing only the three scale fields.Before rollout
release.releasecommit; preserve ignored signing configuration, existing bundle identifiers and app groups.akoi/t1d-infra/docs/loopfollow/LOCAL-INSTALL.mdand the shared signing/export procedure. Choose an unused build number; the installed/TestFlight baseline is 7.1.0 (2). Prepare versions withagvtooland verify matching app/extension marketing versions and build numbers.No controller, treatment-parameter, Nightscout-server, credential, Dexcom Follow alarm or remote-command changes. No TestFlight archive or upload was performed for this PR.