docs(machine-config): kubelet & firewall configuration guides + disruption/chrony fixes#111
docs(machine-config): kubelet & firewall configuration guides + disruption/chrony fixes#111chinameok wants to merge 2 commits into
Conversation
…clarify disruption-policy and chrony restart requirements - Add 'Configuring Kubelet': manage kubelet settings via a --config-dir drop-in with MachineConfig; settings you can change (with recommended ranges), platform-managed settings, and when changes take effect. - Add 'Managing Firewall Ports': open additional ports via a firewalld policy file. - node_disruption: explicit warning that file changes default to None and need a disruption policy to take effect. - managing (chrony): add the node disruption policy required to restart chronyd.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughFour documentation changes are added to the machine-configuration section: a new ChangesMachineConfig Configuration Guides
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying alauda-immutable-infra with
|
| Latest commit: |
8beb89e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73ee4f30.alauda-immutable-infra.pages.dev |
| Branch Preview URL: | https://docs-machine-config-day2.alauda-immutable-infra.pages.dev |
…e kubelet config directory Document the by-design behavior that declaring a unit (e.g. kubelet.service) under systemd.units transfers ownership of the whole unit to Machine Configuration—so removing the MachineConfig removes the base unit and leaves the node NotReady. Clarify why the --config-dir drop-in is written as a storage.files file instead.
Summary
Adds day-2 node-configuration guides to the Machine Configuration section:
--config-dirdrop-in withMachineConfig. Covers enabling the config directory, changing settings, the settings you can change (with recommended ranges), platform-managed settings to avoid, and when changes take effect.Noneand need a disruption policy to take effect.chronyd.Lints clean (
yarn lint: 0 errors).Notes for reviewers
--config-direnabled by default. If the platform enables it by default, that section can be dropped to simplify the guide.release-1.0.Summary by CodeRabbit
chronyd) must use the correct policy action.