Repository navigation
Simplify FromXmlRuleSetTest#testFactoryIgnoreCreateRule by removing try/catch/fail - #292
Draft
siddiqueirshad wants to merge 1 commit into
Draft
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
garydgregory
requested changes
Nov 2, 2026
| } catch (final Exception e) { | ||
| fail("This exception should have been ignored: " + e.getClass().getName()); | ||
| } | ||
| assertDoesNotThrow( () -> newLoader( createRules( rules ) ).newDigester().parse( new StringReader( xml ) ), |
Member
There was a problem hiding this comment.
Don't use assertDoesNotThrow, it's just clutter IMO. Why would you even do that on the last and only assert in a test?
garydgregory
marked this pull request as draft
November 2, 2026 13:29
…ry/catch/fail boilerplate
siddiqueirshad
force-pushed
the
fix-commons-digester-issues
branch
from
November 2, 2026 15:23
59616cf to
21233b1
Compare
siddiqueirshad
changed the title
Author
|
Hi @garydgregory, thank you for the feedback! You're completely right. I have removed �ssertDoesNotThrow and simply let the test method execute directly without the redundant try/catch/fail block, and reverted the changes to changes.xml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize exception verification in \FromXmlRuleSetTest#testFactoryIgnoreCreateRule\ to use JUnit 5 \�ssertDoesNotThrow\ consistent with \�ssertThrows\ in the same test class, and close missing parenthesis and correct grammar in \src/changes/changes.xml.