Skip to content

Simplify FromXmlRuleSetTest#testFactoryIgnoreCreateRule by removing try/catch/fail #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
siddiqueirshad wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Simplify FromXmlRuleSetTest#testFactoryIgnoreCreateRule by removing try/catch/fail #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...igester3-core/src/test/java/org/apache/commons/digester3/xmlrules/FromXmlRuleSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

import java.io.InputStream;
import java.io.StringReader;
Expand Down Expand Up @@ -171,16 +170,12 @@ void testFactoryCreateRule()
}

@Test
void testFactoryIgnoreCreateRule()
void testFactoryIgnoreCreateRule() throws Exception
{
final URL rules = getClass().getResource( "testfactoryignore.xml" );

final String xml = "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><foo/></root>";
try {
newLoader(createRules(rules)).newDigester().parse(new StringReader(xml));
} catch (final Exception e) {
fail("This exception should have been ignored: " + e.getClass().getName());
}
newLoader( createRules( rules ) ).newDigester().parse( new StringReader( xml ) );
}

@Test
Expand Down