Repository navigation
Retry inconsistent region metadata while waiting for migrations - #19163
Merged
CRZbulabula merged 1 commit intoNov 6, 2026
Merged
Conversation
Treat transient cross-node SHOW REGIONS mismatches as unmet conditions in migration waits while preserving their deadlines and final assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parallel
SHOW REGIONSqueries can observe different stages of an asynchronous region migration. For example, one query can return replicas{1,3}while another returns{1,2,3}. The cluster test result set then throwsInconsistentDataExceptionwhile comparing rows, aborting the migration wait and triggering cluster teardown before its deadline.Retry this exception in four existing migration waits: Stream consensus-directory preservation, IoTConsensus empty-deletion and compression-ratio checks, and the replica-membership helper shared by tree/table multi-data-directory deletion tests. An inconsistent observation is treated as an unmet condition. The original one-minute or ten-minute deadlines and all final assertions remain unchanged.
Tests
IoTDBRegionMigrateNormalForIoTV2StreamIT(3 cases)IoTDBRegionMigrateWithLastEmptyDeletionIT(1 case)IoTDBRegionMigrateWithCompressionRatioIT(1 case)IoTDBRegionMigrateWithDeletionMultiDataDirIT(1 case)IoTDBRegionMigrateWithDeletionMultiDataDirTableIT(1 case)with-integration-tests,ClusterITwith explicitClusterIT,TableClusterIT, andDailyITcategory selection. Reactor verification forintegration-testand its dependencies, including Spotless checks, passed.Side effects and risks
A persistent metadata inconsistency now fails at the existing polling deadline instead of aborting immediately. Retrying is limited to
InconsistentDataExceptionin these migration waits; other exceptions still propagate, and the shared result-set consistency checks remain enabled. Production behavior is unchanged.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
IoTDBRegionMigrateNormalForIoTV2StreamIT: retries transient metadata inconsistencies before checking consensus directories.IoTDBRegionMigrateWithLastEmptyDeletionIT: retries inconsistent membership observations during migration.IoTDBRegionMigrateWithCompressionRatioIT: retries inconsistent region observations in the post-migration compression-ratio wait.RegionMigrateFileAssertions: applies the same retry policy to the shared replica-membership wait.