Skip to content

Retry inconsistent region metadata while waiting for migrations #19163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CRZbulabula merged 1 commit into from
Nov 6, 2026
+12 −0
Merged

Retry inconsistent region metadata while waiting for migrations #19163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...g/apache/iotdb/confignode/it/regionmigration/pass/commit/RegionMigrateFileAssertions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import org.apache.iotdb.it.env.EnvFactory;
import org.apache.iotdb.it.env.cluster.node.DataNodeWrapper;
import org.apache.iotdb.itbase.exception.InconsistentDataException;

import org.awaitility.Awaitility;
import org.junit.Assert;
Expand Down Expand Up @@ -67,8 +68,10 @@ static void awaitModsVisibleOnReplicas(

static void awaitRegionReplicas(
Statement statement, int dataRegionId, Set<Integer> expectedReplicaDataNodeIds) {
// Parallel SHOW REGIONS queries can observe different stages of the migration.
Awaitility.await()
.atMost(10, TimeUnit.MINUTES)
.ignoreException(InconsistentDataException.class)
.pollDelay(1, TimeUnit.SECONDS)
.pollInterval(2, TimeUnit.SECONDS)
.untilAsserted(
Expand Down
3 changes: 3 additions & 0 deletions ...gnode/it/regionmigration/pass/commit/stream/IoTDBRegionMigrateNormalForIoTV2StreamIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.iotdb.it.env.EnvFactory;
import org.apache.iotdb.it.framework.IoTDBTestRunner;
import org.apache.iotdb.itbase.category.ClusterIT;
import org.apache.iotdb.itbase.exception.InconsistentDataException;
import org.apache.iotdb.rpc.TSStatusCode;

import org.awaitility.Awaitility;
Expand Down Expand Up @@ -115,8 +116,10 @@ public void migrationShouldPreserveOtherRegionFiles() throws Exception {
Set<Integer> expectedDataNodes = new HashSet<>(regionMap.get(selectedRegion));
expectedDataNodes.remove(source);
expectedDataNodes.add(destination);
// Parallel SHOW REGIONS queries can observe different stages of the migration.
Awaitility.await()
.atMost(1, TimeUnit.MINUTES)
.ignoreException(InconsistentDataException.class)
.untilAsserted(
() ->
Assert.assertEquals(
Expand Down
3 changes: 3 additions & 0 deletions ...fignode/it/regionmigration/pass/daily/iotv1/IoTDBRegionMigrateWithCompressionRatioIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.iotdb.it.env.EnvFactory;
import org.apache.iotdb.it.framework.IoTDBTestRunner;
import org.apache.iotdb.itbase.category.DailyIT;
import org.apache.iotdb.itbase.exception.InconsistentDataException;

import org.apache.tsfile.utils.Pair;
import org.awaitility.Awaitility;
Expand Down Expand Up @@ -112,8 +113,10 @@ public void testWithCompressionRatio() throws Exception {
"migrate region %d from %d to %d", dataRegionIdForTest, leaderId, newLeaderId));

double finalCompressionRatioBeforeMigration = compressionRatioBeforeMigration[0];
// Parallel SHOW REGIONS queries can observe different stages of the migration.
Awaitility.await()
.atMost(10, TimeUnit.MINUTES)
.ignoreException(InconsistentDataException.class)
.pollDelay(1, TimeUnit.SECONDS)
.untilAsserted(
() -> {
Expand Down
3 changes: 3 additions & 0 deletions ...ignode/it/regionmigration/pass/daily/iotv1/IoTDBRegionMigrateWithLastEmptyDeletionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.iotdb.it.env.EnvFactory;
import org.apache.iotdb.it.framework.IoTDBTestRunner;
import org.apache.iotdb.itbase.category.DailyIT;
import org.apache.iotdb.itbase.exception.InconsistentDataException;

import org.apache.tsfile.utils.Pair;
import org.awaitility.Awaitility;
Expand Down Expand Up @@ -90,8 +91,10 @@ public void testWithLastEmptyDeletion() throws Exception {
String.format(
"migrate region %d from %d to %d", dataRegionIdForTest, leaderId, newLeaderId));

// Parallel SHOW REGIONS queries can observe different stages of the migration.
Awaitility.await()
.atMost(10, TimeUnit.MINUTES)
.ignoreException(InconsistentDataException.class)
.pollDelay(1, TimeUnit.SECONDS)
.until(
() -> {
Expand Down
Loading