Repository navigation
fix(test): avoid GCC 13.3 ICE in floating-point comparator - #530
Merged
SteNicholas merged 1 commit intoNov 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #529.
The default Debug build crashes GCC 13.3 while instantiating
FieldsComparatorTest::CheckFloatingPointOrder<float>: the negated local constant is passed directly into the variant-backed row generator. Materialize the negated NaN asTbefore that conversion to avoid the compiler ICE.The existing float/double ordering assertions continue to cover infinities, signed zero, NaNs, and sign-flipped NaN equality. A scan of 2,195 repository-owned C++ files and review of the other negated floating/template-constant candidates found no additional confirmed instance of this conversion pattern.
Tests
cmake --build build --parallel 96andcmake --build build-clang --parallel 96.build/debug/paimon-common-test --gtest_filter='FieldsComparatorTest.*': 6/6 passed with GCC 13.3.0.build-clang/debug/paimon-common-test --gtest_filter='FieldsComparatorTest.*': 6/6 passed with Clang 18.1.3.ctest --test-dir build -L unittest --output-on-failure --parallel 96: 32/32 test executables passed, 201.32 seconds.pre-commit run --all-files --show-diff-on-failurein an isolated validation checkout at the same base commit plus this patch.git diff --checkpassed.API and Format
Unchanged: this only adjusts one test initialization.
Documentation
No user-facing documentation changes are needed for this test-only compiler workaround.
Generative AI tooling
Generated-by: OpenAI Codex 26.1029.70936