Repository navigation
refactor(frontend): remove dataset version creator dead code - #9070
Queued
aglinxinyuan wants to merge 1 commit into
Queued
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
isCreateButtonDisabled is never written, so drop it and its always- false operand in the create button's [disabled] binding. Drop the unused FormBuilder injection, and the .file-uploader and .help-text rules that no element in this template has.
Contributor
Automated Reviewer SuggestionsBased on the
|
github-actions
Bot
added
refactor
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
Review effort: Lite
kunwp1
approved these changes
Oct 21, 2026
Copilot stopped reviewing on behalf of
kunwp1 due to an error
October 21, 2026 06:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes dead code from
UserDatasetVersionCreatorComponent. +3/−19 lines. There is no behaviour change.isCreateButtonDisabled: nothing ever writes it, so it is alwaysfalse. The create button's[disabled]="isCreateButtonDisabled || isCreating"becomes[disabled]="isCreating", which evaluates identically.formBuilderinjection: nothing reads it.FormBuilderis provided in root, so dropping the parameter (and its import) changes nothing..file-uploaderand.toggle-item .help-text: the component uses emulated encapsulation and no element in its template has either class. Thefiles-uploaderchild renders its own.file-uploader, which this stylesheet can't reach.History
isCreateButtonDisabled,formBuilderand.file-uploader. #3663 (2025-08-17), "feat: adding option to allow owner to disallow downloading datasets":.help-text<div class="file-uploader">wrapper.isCreateButtonDisabled,formBuilderand.help-textwere never usedisCreateButtonDisabledandformBuilderhave been unused for the two and a half years since they were added.Any related issues, documentation, discussions?
Closes #9067
How was this PR tested?
No new tests. The component spec's create-button cases still cover the
[disabled]binding throughisCreating.From
frontend/:npx ng test --watch=false --include='**/user-dataset-version-creator.component.spec.ts' --include='**/user-dataset.component.spec.ts' --include='**/result-exportation.component.spec.ts': 3 files, 105 tests, all pass. The last two specs cover the component's two modal hosts.yarn format:ci: clean.npx ng build: success.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code