Skip to content

refactor(frontend): remove dataset version creator dead code #9070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aglinxinyuan wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −19
Open

refactor(frontend): remove dataset version creator dead code #9070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
nz-button
nzType="primary"
(click)="onClickCreate()"
[disabled]="isCreateButtonDisabled || isCreating"
[disabled]="isCreating"
class="create-btn">
Create
</button>
Expand Down
13 changes: 0 additions & 13 deletions ...dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@
}
}

.file-uploader {
height: 40%;
width: 90%;
margin: auto;
}

.dataset-toggles {
margin-top: 16px;
margin-bottom: 16px;
Expand All @@ -76,11 +70,4 @@
min-width: 80px;
font-weight: 500;
}

.help-text {
margin-left: 8px;
font-size: 12px;
color: #999;
font-style: italic;
}
}
7 changes: 2 additions & 5 deletions ...r-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import { Component, inject, OnInit } from "@angular/core";
import { FormBuilder, FormGroup, FormsModule } from "@angular/forms";
import { FormGroup, FormsModule } from "@angular/forms";
import { FormlyFieldConfig, FormlyModule } from "@ngx-formly/core";
import { DatasetService } from "../../../../../service/user/dataset/dataset.service";
import { Dataset } from "../../../../../../common/type/dataset";
Expand Down Expand Up @@ -58,8 +58,6 @@ export class UserDatasetVersionCreatorComponent implements OnInit {

readonly did: number = inject(NZ_MODAL_DATA)?.did ?? undefined;

isCreateButtonDisabled: boolean = false;

public form: FormGroup = new FormGroup({});
model: any = {};
fields: FormlyFieldConfig[] = [];
Expand All @@ -75,8 +73,7 @@ export class UserDatasetVersionCreatorComponent implements OnInit {
constructor(
private modalRef: NzModalRef,
private datasetService: DatasetService,
private notificationService: NotificationService,
private formBuilder: FormBuilder
private notificationService: NotificationService
) {}

ngOnInit() {
Expand Down
Loading