Repository navigation
Conversation
Empty commit so a draft pull request can run the check and E2E workflows against the current actor-runtime head. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015JzfLYa5CHCXxfzC1No3gV
Contributor
Author
|
E2E Tests (ubuntu-latest) is red here, but not because of this branch.
Generated by Claude Code |
Contributor
Author
|
Local Tests (windows-2025, 24) is red for a reason that is this branch's, unlike the E2E one above:
Both are test assumptions, not CLI bugs; the ubuntu jobs pass. Fix in #1494, not ported here since this PR is a probe and will be closed. Generated by Claude Code |
Pijukatel
added a commit
that referenced
this pull request
Oct 12, 2026
## What The CI probe [#1493](#1493) showed `Local Tests (windows-2025)` red on `actor-runtime` because two branch-only tests assume POSIX paths and modes. The CLI code is fine on Windows; only the assertions were wrong. - `test/local/lib/runtime-source-context.test.ts`: expected roots were built with `join('/repo')`, which is `\repo` on Windows, while `resolveDockerContext` uses `resolve()` and gets `D:\repo`. The test now resolves the same way. - `test/local/commands/push-monorepo.test.ts`: the tarball mode assertion expected `0o755` after `chmod`, but Windows has no execute bit, so the archive records `0o666`. That one assertion is skipped on Windows, as the existing mode tests in `auth-file` and `credentials` already do; the rest of the test still runs there. Test-only change; no CLI behavior changes. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft only. Opened to run the check and E2E workflows against the current
actor-runtimehead (5f20318, master merged in). Contains a single empty commit; close once the results are read.🤖 Generated with Claude Code
https://claude.ai/code/session_015JzfLYa5CHCXxfzC1No3gV
Generated by Claude Code