Repository navigation
test(runtime): make the monorepo push tests pass on Windows - #1494
Merged
Merged
Conversation
Two actor-runtime tests assumed POSIX paths and modes:
- resolveDockerContext's expected roots were built with join('/repo'),
which on Windows gives '\repo' while the command's resolve() gives
'D:\repo'. The test now resolves the same way.
- The tarball mode assertion expected 0o755 after chmod, but Windows has
no execute bit, so the archive records 0o666. The assertion is skipped
there, as the other mode tests already do.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015JzfLYa5CHCXxfzC1No3gV
Pijukatel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CI probe #1493 showed
Local Tests (windows-2025)red onactor-runtimebecause two branch-only tests assume POSIX paths and modes. The CLI code is fine on Windows; only the assertions were wrong.test/local/lib/runtime-source-context.test.ts: expected roots were built withjoin('/repo'), which is\repoon Windows, whileresolveDockerContextusesresolve()and getsD:\repo. The test now resolves the same way.test/local/commands/push-monorepo.test.ts: the tarball mode assertion expected0o755afterchmod, but Windows has no execute bit, so the archive records0o666. That one assertion is skipped on Windows, as the existing mode tests inauth-fileandcredentialsalready do; the rest of the test still runs there.Test-only change; no CLI behavior changes.