Repository navigation
Conversation
KazuCocoa
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page class: ...in a web context (iOS and Android) andget_android_inspect(class_name)on HTML source raiseNoMethodError: undefined method '[]=' for nilwhen the page has text after a matching element closes, for example<div><a href="/login">Sign in</a> or register</div>withpage class: :a.With a filter set,
HTMLElementsonly pushes matching elements onto its stack. After the matching element closes, the stack is empty,@skip_elementis stillfalse, andcharacterswrites the following text to@element_stack.last, which isnil.This change makes
charactersignore text when no element is on the stack. Unfiltered output does not change.Closes #1147
How Has This Been Tested?
test_html_elements_ignores_text_after_filtered_elementtotest/regression_test.rb. It fails withNoMethodErrorwithout the fix and passes with it.bundle exec rake test: 44 tests, 101 assertions, 0 failures, 0 errors.Checklist
bundle exec rake rubocop