Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/appium_lib/common/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ def end_element(name)
end

def characters(chars)
return if @skip_element
# Text that follows a closed filtered element has no element to attach to.
return if @skip_element || @element_stack.empty?

element = @element_stack.last
element[:text] = chars
Expand Down
8 changes: 8 additions & 0 deletions test/regression_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,14 @@ def test_html_elements_result_continues_after_attribute_free_elements
assert_equal "\na\n href: /login\n text: Sign in\n", parser.document.result
end

def test_html_elements_ignores_text_after_filtered_element
parser = Nokogiri::HTML::SAX::Parser.new(Appium::Common::HTMLElements.new)
parser.document.filter = :a
parser.parse('<html><body><div><a href="/login">Sign in</a> or register</div></body></html>')

assert_equal "\na\n href: /login\n text: Sign in\n", parser.document.result
end

def test_log_event_writer_raises_no_driver_and_argument_errors
driver = build_driver
assert_raises(Appium::NoDriverInstanceError) { driver.log_event = { vendor: 'appium', event: 'funEvent' } }
Expand Down
Loading