Skip to content

fix(deps): raise vite to 7.3.7 and patch launch-editor - #49

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix/security-vite
Nov 4, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
fix/security-vite

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

Supersedes #44.

#44 writes ^7.3.7 into pnpm-lock.yaml while package.json keeps ^7.1.7, so pnpm install --frozen-lockfile fails with ERR_PNPM_OUTDATED_LOCKFILE. It also leaves launch-editor 2.14.1 in the tree through the TanStack devtools.

  • Raises vite to ^7.3.7 in package.json.
  • Overrides launch-editor to ^2.14.2 (GHSA-r825-w8mm-5pxw and related) in package.json for npm and pnpm-workspace.yaml for pnpm.
  • Regenerates pnpm-lock.yaml with pnpm 10 and package-lock.json. Both now resolve vite 7.3.7 and launch-editor 2.14.2.

Verified locally: pnpm install --frozen-lockfile, build, test, lint and check, plus npm ci --dry-run before the override.

bun.lock is unchanged because CI does not use it here.

Renovate wrote the new vite specifier into pnpm-lock.yaml without touching package.json, so frozen pnpm installs fail. TanStack devtools also keeps launch-editor 2.14.1, which the same advisories cover, so it needs an override in both lockfile managers.
@ghost

ghost commented Nov 4, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

This change raises the Vite dependency to 7.3.7 and overrides launch-editor to 2.14.2 for npm and pnpm. Both lockfiles are updated to resolve those versions.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 4
File Change
package.json Bumps Vite and adds the npm launch-editor override.
pnpm-workspace.yaml Adds the pnpm launch-editor override.
package-lock.json Refreshes the Vite and launch-editor resolutions.
pnpm-lock.yaml Refreshes the Vite and launch-editor resolutions and importer references.
🔇 Filtered out · 1

Findings Hansi considered but did not post.

Finding Why
esbuild 0.27.3 remains vulnerable under Vite Verifier: The locked version is within the advisory's affected range, but the claimed Vite dev-server exposure is not reachable. GHSA-g7r4-m6w7-qqqr affects esbuild's own Windows HTTP server when serving a configured servedir. Inspection of the published vite@7.3.7 code shows Vite creates its HTTP server with node:http/node:http2 and Connect, uses esbuild only for transforms/builds and context.rebuild(), and never calls esbuild's serve API or sets servedir. The repository's dev script runs vite and its configuration does not start an esbuild server. An audit version match alone does not establish this security bug in the application.

Reviewed 3127efd · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit f3a66f6 into main Nov 4, 2026
4 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix/security-vite branch November 4, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant