fix(palette): trim search query before matching (flaky Property 41)#37
Merged
Conversation
The palette filter checked query.trim() for emptiness but matched with the UNTRIMMED query, so 'a ' excluded items containing 'a' — trailing whitespace changed search results. The fast-check exclusion property caught this intermittently (counterexample 'A '; property tests are seed-random, which is why CI was green on some runs and red on others — including the main run after the xyflow merge). Trim before matching in both ComponentPalette and the extracted test copy; 253 frontend tests pass, palette property suite verified across 5 randomized runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent
paletteSearchproperty-test failure (seen on the main CI run after #35, and inside #34's run): the filter trimmed the query only for the emptiness check but matched with the untrimmed string, so a query with trailing whitespace ('A ') wrongly excluded items. Trailing/leading whitespace now never changes results. Verified across 5 randomized fast-check runs + full suite (253 tests).🤖 Generated with Claude Code