Skip to content

fix(palette): trim search query before matching (flaky Property 41) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omrsamer merged 1 commit into from
Jul 20, 2026
Merged

fix(palette): trim search query before matching (flaky Property 41) #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frontend/src/components/palette/ComponentPalette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,11 +349,14 @@ export function ComponentPalette({
new Set(['compute', 'integration', 'security', 'tools', 'connectors'])
);

// Filter items based on search query
// Filter items based on search query. Trim BEFORE matching — an untrimmed
// query like "a " excludes items that contain "a" but not "a " (trailing
// whitespace should never change search results); Property 41 checks the
// trimmed semantics.
const filteredItems = useMemo(() => {
if (!searchQuery.trim()) return PALETTE_ITEMS;

const query = searchQuery.toLowerCase();
const query = searchQuery.trim().toLowerCase();
return PALETTE_ITEMS.filter(
(item) =>
item.label.toLowerCase().includes(query) ||
Expand Down
6 changes: 5 additions & 1 deletion frontend/src/utils/paletteSearch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ import { PALETTE_ITEMS, type PaletteItem } from '../components/palette/Component
export function filterPaletteItems(items: PaletteItem[], query: string): PaletteItem[] {
if (!query.trim()) return items;

const normalizedQuery = query.toLowerCase();
// Trim BEFORE matching (mirrors ComponentPalette): a query like "a " must
// match the same items as "a" — trailing whitespace never changes results.
// Without the trim, the exclusion property fails on counterexamples like
// "A " (item contains "a" but not "a ").
const normalizedQuery = query.trim().toLowerCase();
return items.filter(
(item) =>
item.label.toLowerCase().includes(normalizedQuery) ||
Expand Down
Loading