feat: bump min go version to 1.26 - #638
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 77.02% 82.38% +5.35%
==========================================
Files 36 36
Lines 1419 1419
==========================================
+ Hits 1093 1169 +76
Misses 247 247
+ Partials 79 3 -76 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -1,6 +1,6 @@ | |||
| module github.com/aws/aws-lambda-go | |||
There was a problem hiding this comment.
Questions: if we are releasing 2.0.0, shouldn't we make this some like module github.com/aws/aws-lambda-go/v2?
There was a problem hiding this comment.
good point! actually, maybe we don't need to bump to v2, it seems that raising the minimum version of go is not a breaking change, and usually released a minor version bumps in other packages.
There was a problem hiding this comment.
ie: aws-sdk is not bumping major when they bump go version (ie: aws/aws-sdk-go-v2@d5b9ac6)
There was a problem hiding this comment.
+1 -> Let's follow go's canonical versioning
Raises the project's minimum supported Go version to 1.26, the oldest release that is still supported by upstream Go.
Motivation
Per the official Go release policy, each major Go release is supported only until there are two newer major releases:
As of now, the two most recent major releases are Go 1.27 (latest) and Go 1.26. That makes 1.26 the oldest version that is not end-of-life, Go 1.25 and earlier no longer receive fixes, including security patches.
Pinning our minimum to 1.26 keeps us on a supported toolchain and lets us drop workarounds for EOL versions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.