Skip to content

feat: bump min go version to 1.26 #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxday merged 1 commit into from
Aug 27, 2026
+5 −22
Merged

feat: bump min go version to 1.26 #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-lambda-zip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: install build-lambda-zip on ${{ matrix.platform }}
strategy:
matrix:
go-version: [1.12, 1.13]
go-version: [1.27, 1.26]
platform: [ubuntu-latest, macos-latest, windows-latest]
steps:
- name: Setup Go
Expand Down
21 changes: 2 additions & 19 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,6 @@ jobs:
go:
- "1.27"
- "1.26"
- "1.25"
- "1.24"
- "1.23"
- "1.22"
- "1.21"
- "1.20"
- "1.19"
- "1.18"
- "1.17"
- "1.16"

steps:
- name: Set up Go ${{ matrix.go }}
Expand All @@ -35,14 +25,6 @@ jobs:
- name: Check out code into the Go module directory
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- name: Edit the go.mod file to allow tests to run for versions of go before 1.16
run: >
if [[ ${{ matrix.go }} < "1.16" ]]; then
sed -i.bak 's/^.*retract.*$//' go.mod
else
echo "no edit required"
fi

- name: go test
run: go test -v -race ./...

Expand All @@ -52,7 +34,8 @@ jobs:
strategy:
matrix:
go:
- "1.25"
- "1.27"
- "1.26"
steps:
- name: Set up Go ${{ matrix.go }}
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/aws/aws-lambda-go

@anzheyazzz anzheyazzz Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions: if we are releasing 2.0.0, shouldn't we make this some like module github.com/aws/aws-lambda-go/v2?

ref: https://go.dev/doc/modules/version-numbers

@maxday maxday Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! actually, maybe we don't need to bump to v2, it seems that raising the minimum version of go is not a breaking change, and usually released a minor version bumps in other packages.

@maxday maxday Aug 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie: aws-sdk is not bumping major when they bump go version (ie: aws/aws-sdk-go-v2@d5b9ac6)

@trivenay trivenay Aug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 -> Let's follow go's canonical versioning


go 1.18
go 1.26

require github.com/stretchr/testify v1.7.2

Expand Down
2 changes: 1 addition & 1 deletion lambdaurl/testdata/testfunc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ require github.com/aws/aws-lambda-go v1.40.0

replace github.com/aws/aws-lambda-go => ../../../

go 1.20
go 1.26
Loading