Skip to content

events: keep CodeBuildNumber exact for every int32 #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yeagerist0 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

events: keep CodeBuildNumber exact for every int32 #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions events/codebuild.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ type CodeBuildNumber int32

// MarshalJSON converts a given CodeBuildNumber to json
func (n CodeBuildNumber) MarshalJSON() ([]byte, error) {
return json.Marshal(float32(n))
return json.Marshal(float64(n))
}

// UnmarshalJSON converts a given json to a CodeBuildNumber
func (n *CodeBuildNumber) UnmarshalJSON(data []byte) error {
var f float32
var f float64
if err := json.Unmarshal(data, &f); err != nil {
return err
}
Expand Down
16 changes: 16 additions & 0 deletions events/codebuild_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,3 +310,19 @@ func TestUnmarshalCodeBuildEvent(t *testing.T) {
require.Equal(t, testcase.expect, actual)
}
}

func TestCodeBuildNumberKeepsEveryInt32(t *testing.T) {
// 16777217 is 2^24+1, the first integer a float32 cannot hold.
for _, want := range []CodeBuildNumber{1, 16777217, 2147483647} {
b, err := json.Marshal(want)
require.NoError(t, err)

var got CodeBuildNumber
require.NoError(t, json.Unmarshal(b, &got))
require.Equal(t, want, got)
}

var got CodeBuildNumber
require.NoError(t, json.Unmarshal([]byte("16777217"), &got))
require.Equal(t, CodeBuildNumber(16777217), got)
}
Loading