Repository navigation
events: keep CodeBuildNumber exact for every int32 - #647
Open
Yeagerist0 wants to merge 1 commit into
Open
Yeagerist0 wants to merge 1 commit into
Yeagerist0 wants to merge 1 commit into
Conversation
CodeBuildNumber went through float32 in both directions, which holds integers exactly only up to 2^24. A build number above 16777216 was silently rounded on unmarshal (16777217 became 16777216). Use float64, which represents every int32 exactly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
+ Coverage 82.04% 82.17% +0.13%
==========================================
Files 37 37
Lines 1487 1487
==========================================
+ Hits 1220 1222 +2
+ Misses 264 262 -2
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeBuildNumbergoes throughfloat32when it is marshalled and unmarshalled. A float32 holds integers exactly only up to 2^24, so16777217unmarshals as16777216.Switched both directions to
float64, which holds every int32. The test fails on main (expected: 16777217, actual: 16777216) and passes with the change;go test ./eventsis green.Disclosure: I used Claude Code to help find and write this; I reproduced the bug and ran the tests myself.