Skip to content

events: keep the fractional part in DurationSeconds and DurationMinutes #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yeagerist0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

events: keep the fractional part in DurationSeconds and DurationMinutes #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions events/duration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func (duration *DurationSeconds) UnmarshalJSON(data []byte) error {
return err
}

*duration = DurationSeconds(time.Duration(seconds) * time.Second)
*duration = DurationSeconds(time.Duration(seconds * float64(time.Second)))
return nil
}

Expand All @@ -34,7 +34,7 @@ func (duration *DurationMinutes) UnmarshalJSON(data []byte) error {
return err
}

*duration = DurationMinutes(time.Duration(minutes) * time.Minute)
*duration = DurationMinutes(time.Duration(minutes * float64(time.Minute)))
return nil
}

Expand Down
27 changes: 27 additions & 0 deletions events/duration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package events

import (
"encoding/json"
"testing"
"time"

"github.com/stretchr/testify/require"
)

func TestDurationSecondsKeepsFraction(t *testing.T) {
var d DurationSeconds
require.NoError(t, json.Unmarshal([]byte("1.5"), &d))
require.Equal(t, 1500*time.Millisecond, time.Duration(d))

require.NoError(t, json.Unmarshal([]byte("36"), &d))
require.Equal(t, 36*time.Second, time.Duration(d))
}

func TestDurationMinutesKeepsFraction(t *testing.T) {
var d DurationMinutes
require.NoError(t, json.Unmarshal([]byte("1.5"), &d))
require.Equal(t, 90*time.Second, time.Duration(d))

require.NoError(t, json.Unmarshal([]byte("60"), &d))
require.Equal(t, 60*time.Minute, time.Duration(d))
}
Loading