Repository navigation
events: keep the fractional part in DurationSeconds and DurationMinutes - #648
Open
Yeagerist0 wants to merge 1 commit into
Open
Yeagerist0 wants to merge 1 commit into
Yeagerist0 wants to merge 1 commit into
Conversation
UnmarshalJSON decoded the number as a float64 and then converted it to time.Duration before multiplying, which truncates the fraction: 1.5 seconds became 1s and 1.5 minutes became 1m. Multiply in float64 first.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 37 37
Lines 1487 1487
=======================================
Hits 1220 1220
Misses 264 264
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnmarshalJSONdecodes into afloat64but then doestime.Duration(seconds) * time.Second, which truncates before it multiplies.1.5becomes1sand1.5minutes becomes1m, whileMarshalJSONrounds up withmath.Ceil.Multiply in float64 first. Integer inputs behave as before. New tests fail on main (
expected: 1.5s, actual: 1s) and pass now;go test ./eventsis green.Disclosure: I used Claude Code to help find and write this; I reproduced the bug and ran the tests myself.