Repository navigation
events: marshal CodeCommitEventTime from a value receiver - #649
Open
Yeagerist0 wants to merge 1 commit into
Open
Yeagerist0 wants to merge 1 commit into
Yeagerist0 wants to merge 1 commit into
Conversation
MarshalJSON had a pointer receiver, so json.Marshal only used it when
the field was addressable. Marshalling a CodeCommitRecord by value
silently wrote "eventTime":{} instead of the timestamp, which
UnmarshalJSON then cannot read back.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 82.04% 82.07% +0.03%
==========================================
Files 37 37
Lines 1487 1484 -3
==========================================
- Hits 1220 1218 -2
+ Misses 264 263 -1
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeCommitEventTime.MarshalJSONhas a pointer receiver, soencoding/jsononly calls it for addressable values.json.Marshal(record)on aCodeCommitRecord(not&record) writes"eventTime":{}, andUnmarshalJSONcan't read that back.Moved
MarshalJSONto a value receiver;json.Marshalalready writesnullfor a nil pointer, so the explicit nil check is no longer needed. The new test round-trips a record passed by value; it fails on main and passes now.go test ./eventsis green.Disclosure: I used Claude Code to help find and write this; I reproduced the bug and ran the tests myself.