Repository navigation
Conversation
Splinter is unmaintained and should not ship with Bugzilla 6. Remove extensions/Splinter and every reader of its splinter_base param: the /review route, the Splinter Review link on patch attachments in BugModal, the MyDashboard flag link, the Review extension's page hook and request badge link, and the param export in the global header. Patch links in the review badge now fall back to the attachment details page, as other attachments already do. update_params does not drop params that are no longer defined, so upgraded installs keep a stale splinter_base value in data/params. Nothing reads it any more, so it is harmless and is left in place.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1545443
Splinter is unmaintained and should not ship with Bugzilla 6. This removes extensions/Splinter and every reader of its splinter_base param:
Upgrade note: update_params does not drop params that are no longer defined, so upgraded installs keep a stale splinter_base value in data/params. Every reader is removed, so it is harmless; I left it rather than adding param cleanup code.
Tested locally in Docker, on a database that still has splinter_base set (the upgrade case):