Bug 1545443: Remove the Splinter extension

Bugzilla/App.pm

@@ -202,7 +202,6 @@ sub setup_routes {
     '/__version__' => {file => 'version.json', content_type => 'application/json'});
   $r->static_file('/version.json', {content_type => 'application/json'});
 
-  $r->page('/review',        'splinter.html');
   $r->page('/user_profile',  'user_profile.html');
   $r->page('/userprofile',   'user_profile.html');
   $r->page('/request_defer', 'request_defer.html');

extensions/BugModal/template/en/default/bug_modal/activity_stream.html.tmpl

@@ -276,9 +276,6 @@
         <span id="att-[% att.id FILTER none %]-description" itemprop="description">[% att.description FILTER html %]</span></a>
         [% " (obsolete)" IF att.isobsolete; " (deleted)" IF !att.datasize %]
         — <a href="[% link FILTER html %]&amp;action=edit" itemprop="url">Details</a>
-        [% IF att.ispatch && Param('splinter_base') %]
-          — <a href="[% Bugzilla.splinter_review_url(bug.bug_id, att.id) FILTER none %]">Splinter Review</a>
-        [% END %]
       </div>
     </div>
   [% END %]

extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl

@@ -74,12 +74,6 @@
   </div>
 </script>
 
-<script [% script_nonce FILTER none %]>
-  [% IF Param('splinter_base') %]
-    MyDashboard.splinter_base = '[% Bugzilla.splinter_review_base FILTER js %]';
-  [% END %]
-</script>
-
 <div id="mydashboard">
   <div>
     <label class="switch">

extensions/MyDashboard/web/js/flags.js

@@ -92,20 +92,7 @@ $(function () {
         };
 
         var flagNameFormatter = function(o) {
-            if (parseInt(o.data.attach_id)
-                && parseInt(o.data.is_patch)
-                && MyDashboard.splinter_base)
-            {
-                return '<a href="' + MyDashboard.splinter_base +
-                    (MyDashboard.splinter_base.indexOf('?') == -1 ? '?' : '&') +
-                    'bug=' + encodeURIComponent(o.data.bug_id) +
-                    '&attachment=' + encodeURIComponent(o.data.attach_id) +
-                    '" target="_blank" title="Review this patch">' +
-                    o.value.htmlEncode() + '</a>';
-            }
-            else {
-                return o.value.htmlEncode();
-            }
+            return o.value.htmlEncode();
         };
 
         var auto_updateFlagTable = function(o) {

extensions/Review/template/en/default/hook/global/header-start.html.tmpl

@@ -12,8 +12,7 @@
 [% RETURN UNLESS template.name == 'attachment/edit.html.tmpl'
       || template.name == 'attachment/create.html.tmpl'
       || template.name == 'attachment/diff-header.html.tmpl'
-      || template.name == 'bug/create/create.html.tmpl'
-      || template.name == 'pages/splinter.html.tmpl' %]
+      || template.name == 'bug/create/create.html.tmpl' %]
 
 [% style_urls.push('extensions/Review/web/styles/review.css') %]
 [% javascript_urls.push('extensions/Review/web/js/review.js') %]

extensions/Review/web/js/badge.js

@@ -112,19 +112,16 @@ Bugzilla.Review.Badge = class Badge {
      */
     get_link(req) {
         const dup = req.dup_count > 1;
-        const splinter_base = BUGZILLA.param.splinter_base;
         const basepath = BUGZILLA.config.basepath;
         const x_types = ['github-pull-request', 'review-board-request', 'phabricator-request', 'google-doc'];
         const is_patch = req.attach_ispatch;
         const [is_ghpr, is_rbr, is_phr, is_gdoc] = x_types.map(type => req.attach_mimetype === `text/x-${type}`);
         const is_redirect = is_ghpr || is_rbr || is_phr || is_gdoc;
         const is_file = req.attach_id && !is_patch && !is_redirect;
 
-        const link = (is_patch && !dup && splinter_base)
-            ? `${splinter_base}&bug=${req.bug_id}&attachment=${req.attach_id}`
-            : (is_redirect && !dup) ? `${basepath}attachment.cgi?id=${req.attach_id}` // external redirect
-                : ((is_patch || is_file) && !dup) ? `${basepath}attachment.cgi?id=${req.attach_id}&action=edit`
-                    : `${basepath}show_bug.cgi?id=${req.bug_id}`;
+        const link = (is_redirect && !dup) ? `${basepath}attachment.cgi?id=${req.attach_id}` // external redirect
+            : ((is_patch || is_file) && !dup) ? `${basepath}attachment.cgi?id=${req.attach_id}&action=edit`
+                : `${basepath}show_bug.cgi?id=${req.bug_id}`;
 
         const attach_label = (is_patch || is_rbr || is_phr) ? (dup ? `${req.dup_count} patches` : 'a patch')
             : is_ghpr ? (dup ? `${req.dup_count} pull requests` : 'a pull request')