Repository navigation
test(android): retain original helper diagnostics - #4648
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveNo open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
|
This PR is ready at b517ddc. I found no problems in the code, and all 15 checks pass, including Android smoke, which runs the changed route (preflight and catalog snapshots through captureDiagnosticSnapshot with --debug). There are no conflicts. Not blocking, and you can take or leave these: tie the |
* test(android): retain snapshot helper session diagnostics * test(android): preserve verdict when recording snapshot evidence
* test(android): retain snapshot helper session diagnostics * test(android): preserve verdict when recording snapshot evidence
* test(android): retain snapshot helper session diagnostics * test(android): preserve verdict when recording snapshot evidence
* test(android): retain snapshot helper session diagnostics * test(android): preserve verdict when recording snapshot evidence
* test(android): retain snapshot helper session diagnostics * test(android): preserve verdict when recording snapshot evidence
Summary
Retain the original Android smoke preflight and catalog snapshot helper diagnostics, metadata, warnings, and request correlation when the persistent-session assertion fails. Session acquisition diagnostics distinguish unavailable and reused paths; evidence writing cannot change the scenario verdict. The change touches 10 files, including the shared test harness. Related to #4636.
This improves diagnostic visibility only. The original incident cause remains unknown. The strict persistent-session assertion, budgets, fallback, and retry policies are unchanged.
Validation
7ccde11cc409d1973d7e26199af6bb75cfa2db82; tested head:b517ddc2d4a96a58d0e24508a93be92d5e04a255.pnpm check:affected --run --base 7ccde11cc409d1973d7e26199af6bb75cfa2db82 --head b517ddc2d4a96a58d0e24508a93be92d5e04a255: exact-commit receipt, 9 passed, 8 skipped, 1 deduplicated. Full format, quick checks, and focused diagnostic red/green tests passed.a0f99a69b6; root cold-reviewed the follow-up through the tested head and accepted its regressions.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.