Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
|
This PR is ready at 218a1fe: connection provider admission now refuses a declared provider whose plugin is missing or failed, before any daemon or device call. CI is green (15 checks, none failing) and there are no conflicts. Not blocking, take or leave: make |
218a1fe to
76202b8
Compare
|
This head (76202b8) now conflicts with its base after #4621 moved to ccbf9ed, so I removed the ready-for-human label. The earlier clean review still applies to the code. Please rebase onto the new #4621 head. If the range-diff of this PR's own commits is empty, the prior verdict carries forward and the label comes back. Otherwise the new head gets a delta review. |
76202b8 to
d2f18cf
Compare
* fix(plugins): admit connection providers from their host registry * test(plugins): cover routed connection admission * test(plugins): use explicit remote session fixtures * test(plugins): verify routed admission and cleanup * fix(connection): pass host environment through capability decisions * test(connection): isolate stored status output assertions * test(connection): register providers in lease fixtures * test(connection): colocate provider lease fixture
* fix(plugins): admit connection providers from their host registry * test(plugins): cover routed connection admission * test(plugins): use explicit remote session fixtures * test(plugins): verify routed admission and cleanup * fix(connection): pass host environment through capability decisions * test(connection): isolate stored status output assertions * test(connection): register providers in lease fixtures * test(connection): colocate provider lease fixture
* fix(plugins): admit connection providers from their host registry * test(plugins): cover routed connection admission * test(plugins): use explicit remote session fixtures * test(plugins): verify routed admission and cleanup * fix(connection): pass host environment through capability decisions * test(connection): isolate stored status output assertions * test(connection): register providers in lease fixtures * test(connection): colocate provider lease fixture
* fix(plugins): admit connection providers from their host registry * test(plugins): cover routed connection admission * test(plugins): use explicit remote session fixtures * test(plugins): verify routed admission and cleanup * fix(connection): pass host environment through capability decisions * test(connection): isolate stored status output assertions * test(connection): register providers in lease fixtures * test(connection): colocate provider lease fixture
* fix(plugins): admit connection providers from their host registry * test(plugins): cover routed connection admission * test(plugins): use explicit remote session fixtures * test(plugins): verify routed admission and cleanup * fix(connection): pass host environment through capability decisions * test(connection): isolate stored status output assertions * test(connection): register providers in lease fixtures * test(connection): colocate provider lease fixture
Summary
Reject a known provider whose plugin is missing or failed before a remote profile or stored connection uses generic daemon capabilities. Pass the supplied host environment through capability, lease and presentation decisions so each operation reads the correct registry. Generic remote profiles and disconnect cleanup remain supported.
This 13-file, 591-gross-line prerequisite supports #4617 and targets #4621, for #3310 and #4591.
Validation
Published head:
d2f18cff2110e81c8a7b0b391dd02a32a10fe870, based on #4621ccbf9ed. Pinned frozen install/build and exact affected passed: 42 checks passed, 25 skipped, unchanged checkout. All eight commits are patch-identical across the rebase; the complete branch diff is byte-identical.Routed old-source comparisons exposed generic daemon URL errors for missing and failed plugins. Fixed-source tests cover stores, distinct supplied hosts, direct materialization, lease TTL, generic profiles and disconnect. Independent source review covers the implementation; root reviewed the test follow-ups and verified the rebase.
The published conflict is repaired. Hosted results at this head completed: 13 successful, one skipped and one neutral, including Android smoke success. Sentinel reports no open findings, and there are no review threads. The earlier
76202b8Android smoke failure remains unexplained; helper diagnostics from merged #4648 are now included for new CI. This rebase is not an incident repair.Live AWS acceptance passed separately at combined candidate
8c5fabc, including product close and independent service cleanup. Its remaining validation and publication are separate. No merge clearance is claimed.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.