Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 99 files
You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised No open findings. Not in the reviewers' prompt (1 file)
Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/plugins/src/host.ts:31 |
🆕 runHostCommand now replaces the process environment instead of inheriting it |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (1cb2f242aea5).
Review of 12ec6c46 · 17.11.2026 13:53 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 1 still open · 1 no longer raised
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
src/cli/connection/provider-policy.ts:108 |
Unprimed readers classify aws-device-farm as a remote-daemon provider |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (27a4e409dae6).
Review of 4f79a817 · 17.11.2026 09:40 UTC
Apex Sentinel · ✅ Approve
Since the last review: 2 new · 0 still open · 0 no longer raised
2 finding(s): 2 minor.
🟡 Minor (2)
| Where | Finding |
|---|---|
scripts/layering/project-references.test.ts:113 |
🆕 Root workspace-dependency guard weakened from full coverage to a one-way subset |
src/cli/connection/provider-policy.ts:105 |
🆕 Unprimed/uninstalled aws-device-farm now resolves to remote-provider capabilities |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).
Review of 637a41db · 17.11.2026 08:27 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 0 no longer raised
The changes are the same as on f8ad131, so this is that review, not a new one. Comment @apex-sentinel-staging review to review again.
No open findings.
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).
Review of f8ad1315 · 17.11.2026 07:19 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 2 no longer raised
No open findings.
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).
Review of 98dfddb4 · 16.11.2026 21:41 UTC
Apex Sentinel · ✅ Approve
2 finding(s): 2 minor.
🟡 Minor (2)
| Where | Finding |
|---|---|
packages/provider-aws-device-farm/package.json:36 |
Published aws-device-farm manifest omits the connection-verification subpath the sibling plugins publish |
packages/provider-aws-device-farm/tsdown.config.ts:1 |
aws-device-farm tsdown.config duplicates build-config instead of reusing it |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (a30accf38081).
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 98dfddb. The verdict and the full list are in the summary comment.
|
I reviewed 98dfddb and found two problems to fix before merge. CI is green (21 checks, none failing), but no CI job runs the packed AWS plugin smoke, so green CI does not cover the install-from-store route. No conflicts. This PR changes the production route that allocates and releases AWS Device Farm sessions ( run-host-command.ts re-declares The open inline threads on the unqualified install docs still stand: device-clouds.md, plugins.md install, embedded runtimes, daemon stop retry, package README install, changeset file, maxBuffer no-op, stale bundled list and tsdown config copy, plus four lower-priority threads. These do not apply, so please resolve them: script-test skip (the head scans more than base, so nothing is newly dropped), R11 on script tests (it never ran there at base, and root declarations are still enforced), connection-verification export and the same point again (the only importer is a core workspace test, so dropping the dev export is cleaner), ARN format (only the region is parsed), catalog package name (BrowserStack is listed the same way) and README wording (it already scopes the install to all three plugins). Not blocking, and fine to take or leave: Before merge, this needs the live AWS run (or a named blocker), the type and tsdown config copies removed, and the install docs corrected. |
98dfddb to
f8ad131
Compare
f8ad131 to
637a41d
Compare
|
Thanks for the update. At 637a41d, most of the earlier round (98dfddb) is fixed, but two items remain. The duplicated host types are still there: run-host-command.ts:2 re-declares The real Device Farm route still has no evidence. aws-device-farm-webdriver.ts:1 runs Not blocking, and fine to take or leave: the R11 script-test change in The earlier inline threads are fixed at this head, so you can resolve them. That covers the higher-priority threads (for example the device-clouds.md publication wording and the R11 script-test coverage), the four lower-priority threads, and the two threads on ( Smoke Tests fails in the live Android emulator fixture E2E at Before merge, please remove the local |
637a41d to
4f79a81
Compare
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 4f79a81. The verdict and the full list are in the summary comment.
|
Thanks for the update. At 4f79a81 the two problems from the earlier review still stand. All 21 checks pass, and there are no conflicts, but this needs the two changes below before merge.
The production route Not blocking: the Validation paragraph still says hosted checks are pending and that the previous head had an Android failure, so you can update it when the live run is recorded, or leave it. The open inline thread on provider policy capabilities does not apply, so you can resolve it: |
|
This branch now conflicts with main. Please rebase it onto the current main; the open items from the last review still apply, and I will review the rebased head. |
4f79a81 to
12ec6c4
Compare
|
Published the conflict repair at The PR body now records the live blocker precisely: the inspected T3 device inventory exposes only local simulators/emulators, with no admitted bound Device Farm route. AWS account access and project/device/app ARNs have not been verified. A supported cloud route is needed before recording the requested fresh-home packed installation, verification, store-active daemon, session ARN, snapshot and close evidence. The packed fixture is not represented as that live run. Placeholder/trusted-publisher and final combined-manager acceptance holds remain open. At this exact head, affected/full checks passed 42/41 checks with 25 skipped each; released wire and the packed verifier/strict consumer passed. New-head hosted CI is pending. The stack grouping was rebuilt to insert #4636 without deleting branches or PRs. |
|
The earlier conflict report is fixed, and I found no code problems at 12ec6c4. The PR is ready. Not blocking: the new test in The hosted checks for 12ec6c4 show no failing or pending job, and the changes since the last review are a type-import swap and tests. There are no conflicts. The earlier thread on the unprimed provider fallback is resolved without a change, which is right: No live AWS Device Farm run exists. The PR body names the blocker, as #3310 allows, so the Before merge, the maintainer needs to accept the named live-AWS gap for 0.22, and #4579, #4621 and #4636 must merge first, in that order. |
|
AWS live acceptance passed at exact published combined head The public packed CLI installed the AWS plugin in a fresh store. Its SHA512 integrity and installation matched The initial Pixel 10 Pro was busy before allocation. From that same inventory, a single targeted refresh admitted the available Galaxy A15 / Android 14. One connect, one open of Product close passed. Independent AWS reads confirmed the same uniquely owned session reached The earlier The published head removes |
12ec6c4 to
378947d
Compare
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 378947d. The verdict and the full list are in the summary comment.
378947d to
8c5fabc
Compare
…eboot (#4585) LOCAL REPRODUCER — EXPECTED FAILING. Do not merge or include in a gate. Reproduces #4585 at the routed session boundary on agent-device #4539's published object, with real claim files and the composed boot-observation port. No device, ADB, or simctl. Sequence per case: cold `open` of a stopped AVD (readiness boots it, the session records bootedByOpen, and the claim is written for the booted serial after that boot), then a plain `open` on the same identity, then plain `close`. Cases differ only in the boot the observation service reports, and the external-reboot case names a boot epoch that is already in the past when the reopen starts. Recorded results at bcb9196: `pnpm exec vitest run --project unit-core <this file>` -> 1 failed | 2 passed (3) external reboot, then reopen, then plain close: reopen boots nothing (readiness asked once, at cold open; the reopen renewed the existing claim and kept the same ownerToken and boot marker) the reopen stamps claim.updatedAtMs AFTER the foreign boot, so a renewal stamp cannot tell the two boots apart close asked finalizeApplicationClose({ shutdownTarget: true }) and the platform's shutdownTarget ran once; response.data.shutdown was set -> WRONG: the current boot is not the one this session caused same-boot control (observed boot == claim creation): same ask, and it is correct boot observation unavailable: same ask close with no intervening reopen: same ask explicit `close --shutdown`: same ask, and it is correct policy denying device-shutdown: kept running, reports the kept-device warning Detection was measured in a disposable checkout at the same object: the failing case above passes when implicit stop is additionally denied for a current boot that postdates the claim this session's booting open wrote. Anchoring that comparison on the claim's `updatedAtMs` instead does NOT fix the case, and a reopen cannot itself boot the device, so claim creation is the sound anchor. Base identity: reproduction head bcb9196 (#4539 published head) checkout base 873de91 (0.22, "feat: extract AWS Device Farm provider plugin (#4617)") merge-base 7ccde11 873de91 is NOT an ancestor of bcb9196; the five commits 0.22 has beyond the merge-base touch no session, claim, boot or close owner.
…eboot (#4585) LOCAL REPRODUCER — EXPECTED FAILING. Do not merge or include in a gate. Reproduces #4585 at the routed session boundary on agent-device #4539's published object, with real claim files and the composed boot-observation port. No device, ADB, or simctl. Sequence per case: cold `open` of a stopped AVD (readiness boots it, the session records bootedByOpen, and the claim is written for the booted serial after that boot), then a plain `open` on the same identity, then plain `close`. Cases differ only in the boot the observation service reports, and the external-reboot case names a boot epoch that is already in the past when the reopen starts. Recorded results at bcb9196: `pnpm exec vitest run --project unit-core <this file>` -> 1 failed | 2 passed (3) external reboot, then reopen, then plain close: reopen boots nothing (readiness asked once, at cold open; the reopen renewed the existing claim and kept the same ownerToken and boot marker) the reopen stamps claim.updatedAtMs AFTER the foreign boot, so a renewal stamp cannot tell the two boots apart close asked finalizeApplicationClose({ shutdownTarget: true }) and the platform's shutdownTarget ran once; response.data.shutdown was set -> WRONG: the current boot is not the one this session caused same-boot control (observed boot == claim creation): same ask, and it is correct boot observation unavailable: same ask close with no intervening reopen: same ask explicit `close --shutdown`: same ask, and it is correct policy denying device-shutdown: kept running, reports the kept-device warning Detection was measured in a disposable checkout at the same object: the failing case above passes when implicit stop is additionally denied for a current boot that postdates the claim this session's booting open wrote. Anchoring that comparison on the claim's `updatedAtMs` instead does NOT fix the case, and a reopen cannot itself boot the device, so claim creation is the sound anchor. Base identity: reproduction head bcb9196 (#4539 published head) checkout base 873de91 (0.22, "feat: extract AWS Device Farm provider plugin (#4617)") merge-base 7ccde11 873de91 is NOT an ancestor of bcb9196; the five commits 0.22 has beyond the merge-base touch no session, claim, boot or close owner.
* Extract AWS Device Farm provider plugin * refactor(aws-device-farm): consolidate WebDriver imports * test(aws-device-farm): colocate connection coverage * Test packed AWS provider error boundary * refactor(provider-webdriver): remove unused extraction scaffolding * chore(gates): register the AWS packed smoke entry * chore(gates): verify the explicit WebDriver plugin subpath * test(layering): update WebDriver export boundary * chore(gates): separate root dependency ownership from workspace references * chore(gates): check workspace declarations in script test imports * fix(plugins): defer host command execution imports * refactor(webdriver): remove unused provider exports * fix(plugins): preserve supplied command host context * fix: address AWS plugin review findings * fix(aws-device-farm): publish typed plugin entrypoints * test(docs): resolve installed workspace plugins * fix(ci): select moved snapshot differential test * refactor(aws): import host capability types from the plugin SDK * test(aws): cover routed plugin admission * test(aws): register provider for stored lease fixtures * chore(aws): enable package publication
* Extract AWS Device Farm provider plugin * refactor(aws-device-farm): consolidate WebDriver imports * test(aws-device-farm): colocate connection coverage * Test packed AWS provider error boundary * refactor(provider-webdriver): remove unused extraction scaffolding * chore(gates): register the AWS packed smoke entry * chore(gates): verify the explicit WebDriver plugin subpath * test(layering): update WebDriver export boundary * chore(gates): separate root dependency ownership from workspace references * chore(gates): check workspace declarations in script test imports * fix(plugins): defer host command execution imports * refactor(webdriver): remove unused provider exports * fix(plugins): preserve supplied command host context * fix: address AWS plugin review findings * fix(aws-device-farm): publish typed plugin entrypoints * test(docs): resolve installed workspace plugins * fix(ci): select moved snapshot differential test * refactor(aws): import host capability types from the plugin SDK * test(aws): cover routed plugin admission * test(aws): register provider for stored lease fixtures * chore(aws): enable package publication
* Extract AWS Device Farm provider plugin * refactor(aws-device-farm): consolidate WebDriver imports * test(aws-device-farm): colocate connection coverage * Test packed AWS provider error boundary * refactor(provider-webdriver): remove unused extraction scaffolding * chore(gates): register the AWS packed smoke entry * chore(gates): verify the explicit WebDriver plugin subpath * test(layering): update WebDriver export boundary * chore(gates): separate root dependency ownership from workspace references * chore(gates): check workspace declarations in script test imports * fix(plugins): defer host command execution imports * refactor(webdriver): remove unused provider exports * fix(plugins): preserve supplied command host context * fix: address AWS plugin review findings * fix(aws-device-farm): publish typed plugin entrypoints * test(docs): resolve installed workspace plugins * fix(ci): select moved snapshot differential test * refactor(aws): import host capability types from the plugin SDK * test(aws): cover routed plugin admission * test(aws): register provider for stored lease fixtures * chore(aws): enable package publication
* Extract AWS Device Farm provider plugin * refactor(aws-device-farm): consolidate WebDriver imports * test(aws-device-farm): colocate connection coverage * Test packed AWS provider error boundary * refactor(provider-webdriver): remove unused extraction scaffolding * chore(gates): register the AWS packed smoke entry * chore(gates): verify the explicit WebDriver plugin subpath * test(layering): update WebDriver export boundary * chore(gates): separate root dependency ownership from workspace references * chore(gates): check workspace declarations in script test imports * fix(plugins): defer host command execution imports * refactor(webdriver): remove unused provider exports * fix(plugins): preserve supplied command host context * fix: address AWS plugin review findings * fix(aws-device-farm): publish typed plugin entrypoints * test(docs): resolve installed workspace plugins * fix(ci): select moved snapshot differential test * refactor(aws): import host capability types from the plugin SDK * test(aws): cover routed plugin admission * test(aws): register provider for stored lease fixtures * chore(aws): enable package publication
* Extract AWS Device Farm provider plugin * refactor(aws-device-farm): consolidate WebDriver imports * test(aws-device-farm): colocate connection coverage * Test packed AWS provider error boundary * refactor(provider-webdriver): remove unused extraction scaffolding * chore(gates): register the AWS packed smoke entry * chore(gates): verify the explicit WebDriver plugin subpath * test(layering): update WebDriver export boundary * chore(gates): separate root dependency ownership from workspace references * chore(gates): check workspace declarations in script test imports * fix(plugins): defer host command execution imports * refactor(webdriver): remove unused provider exports * fix(plugins): preserve supplied command host context * fix: address AWS plugin review findings * fix(aws-device-farm): publish typed plugin entrypoints * test(docs): resolve installed workspace plugins * fix(ci): select moved snapshot differential test * refactor(aws): import host capability types from the plugin SDK * test(aws): cover routed plugin admission * test(aws): register provider for stored lease fixtures * chore(aws): enable package publication
Summary
Extract AWS Device Farm into a managed provider plugin. Core retains metadata and uses the plugin SDK for provider execution. This 107-file change builds on #4636 → #4621 → #4579. Closes #3310.
Install a local tarball with
agent-device plugins add ./aws-device-farm.tgz. Empty npm placeholders are not usable plugin releases. Verified placeholder tags and maintainer-attested OIDC satisfy the package-transition prerequisites;privateis removed.Validation
Published head:
8c5fabc15e261b9eb67fd60fe16e3c049f1251fb, rebased onto0.22at9717295. All 21 AWS patches and the complete layer diff are unchanged. The public conflict is resolved.Exact-head affected/full gates passed 42/41 checks respectively, each with 25 skips and an unchanged checkout. Released-wire compatibility passed against v0.21.38 with the protocol unchanged. Packed AWS failure-contract, isolated CLI and strict TypeScript-consumer checks passed; the consumer uses repository Node types. Public manager installation and compatible selection passed for both provider tarballs.
AWS live acceptance passed at this exact head: Galaxy A15 / Android 14 connect/open and an interactive snapshot with 11 nodes. Product close passed; independent AWS reads confirmed the owned session
COMPLETED / PASSED, and the daemon stopped without fallback. Evidence and archive hashes.Hosted checks are complete at this head: 18 successful, two skipped and one neutral. Sentinel reports no open findings; its prompt excludes the generated lockfile. All 22 review threads are resolved. The earlier provisioning failure remains separately attributed. Readiness labels belong to the Chief of Staff; no npm release or merge action is claimed.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.