Repository navigation
Conversation
…ation Move the off-screen refusal core and its selector and @ref refusal shapes into @agent-device/selectors/interaction-offscreen, and move describeNonHittableTarget into interaction-targeting. The daemon cannot import command-runtime, so this lets the find focus seam apply the same rules as the acting paths. throwIfOffscreenInteractionTarget stays the runtime paths' enforcement point and supplies the backend rescue hook. The thin assertVisible*Target wrappers fold into their three call sites, which keeps command-runtime's eager closure at its merge-base weight. Refs callstack#3734 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ones find focus and the focus leg of find type dispatch their own point, so they skipped two rules the acting paths run. A closed-drawer match was focused at coordinates outside the viewport and reported success, and a target still reporting hittable: false after promotion answered without the targetHittable/hint annotation press, click and fill give. The seam now runs the shared off-screen rule on the node it would focus, with the offscreen_ref refusal shape and the iOS live-read rescue (the find-focus and find-type uses declare querySelector as conditional, like the captured acting uses). find's ranking still prefers an on-screen twin first. Both responses carry the shared non-hittable annotation. This closes the offscreen and nonHittable cells of the find-focus-dispatch row. targetStability stays waived: ADR 0039 keeps one admission loop in command runtime and keeps find's carried targets out of it, so closing it needs an ADR decision, which the waiver now states. Refs callstack#3734 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the PR. The code change looks right at c97e5b9, but one live check is still missing before merge. The find focus/type path now refuses before dispatch and, on iOS, sends a new Could the rescue be simpler? Keep the selectors move and the Not blocking, and fine to take or leave: find.ts:513 keeps a second rescue policy for #1542 beside the tap rescue. The two Body rules runs that are not passing were cancelled as superseded, and that job checks PR body text, which this diff does not touch, so the checks look unrelated to the change. Tests and |
|
Note 🤖 Gemini 4 Neon responding on behalf of samanyudas Recorded the live iOS Simulator verification on 1. On-screen field (
|
|
The live iOS run on c97e5b9 covers what the review asked for: on-screen focus and type are unchanged with no Warning line; the off-screen target is refused with |
* origin/main: fix(auth): send a stored CLI session only to the cloud that issued it (#4921) refactor(reasons): declare the daemon reasons in ReasonTable rows (#4936) fix(cli): drop --remote-config from auth and skip reading it for unsupported commands (#4957) refactor(snapshot): deduplicate system-surface projections and warnings (#4959) fix(find): enforce offscreen and non-hittable guarantees on focus (#4954) feat(auth): store a rotated CLI session credential and show the login code (#4833) fix(daemon): report Windows SIGTERM daemon exits as forced (#4659) # Conflicts: # packages/capture-kit/src/snapshot-quality-verdict.ts # packages/command-runtime/src/commands/interaction/runtime/target-visibility-stages.ts # packages/contracts/src/device-inventory.ts # packages/daemon/src/execution/interaction/internal/__tests__/find.test.ts # packages/daemon/src/execution/interaction/internal/find-target-capture.ts # packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts # website/docs/docs/error-reasons.md
Summary
Close the
offscreenandnonHittablewaivers onfind-focus-dispatchinpackages/contracts/src/interaction-guarantees.ts. Refs #3734.throwIfOffscreenTargetanddescribeNonHittableTargetinto@agent-device/selectorssocommand-runtimeanddaemonshare one rule.find focusandfind typetargets; limit iOS rescue to one exactidorlabelprobe match and mark rescued targetshittable: true.targetHittable: falseandhintonfindresponses,FindCommandResponseData, CLI stderr warnings, and MCP text.targetStabilitywaived onfind-focus-dispatchpending an ADR 0039 decision.Before / after
Before:
find focusandfind typedispatched off-screen points and reported silent success on non-hittable targets.After: off-screen targets fail with a
find-specific retry hint, non-hittable targets includetargetHittable: falseand a warning hint, and iOS rescue verifies exact target identity.Validation
c97e5b99a:pnpm check:affected --runpassed 22/23 gates (fullunit,format,lint,typecheck,layering,fallow,build,package,vitest-related) plus all 20 other local gates;depgraphexceeded its 5 s CPU budget locally on both branch and unchanged base under host load.origin/mainand pass onc97e5b99a.Reviewed with sol-loop: 4 rounds with gpt-6.2-sol. Sol verdict: approved.
Created with Claude Opus 5.5 and Gemini 4 Neon in T3 Code.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.