Repository navigation
refactor(linux): drop the request-scoped Linux tool provider - #4955
Conversation
Size Report
Startup median (7 runs, lower is better):
|
The Linux tool provider had no production producer: nothing but tests ever resolved one, and the family already answers every desktop intent through the PlatformHost its plugin was set up with. Remove the request-scoped seam and keep the provider vocabulary inside packages/platform-linux. Provider-backed integration scenarios now drive the family through a fake PlatformHost installed with the plugin's own setup, so the real inventory, runtime, interactor and tool selection are the code under test.
a7c0640 to
195f72c
Compare
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
The code in 195f72c is ready to merge. The Linux provider change keeps production behavior the same, because no request ever scoped a provider at base. No conflicts. The 'Body rules' run was cancelled and one other check is still in progress. Neither exercises the Linux plugin, the request-provider composition or the provider scenarios this diff changes, and all code jobs pass. Merge needs only those two checks to finish. Not blocking, and these can be taken or left: (1) the Not verified here: tests and gates were not run, and the line-count claims come from the PR body and CI. The #4878 core tarball byte-delta measurement for #4676 is also not verified, so 'Closes #4878' is only partly checked. |
Summary
The Linux tool provider had no production producer: nothing outside tests ever resolved one, and the family already answers every desktop intent through the
PlatformHostits plugin was set up with. This removes the request-scoped seam (thelinuxToolProviderresolver key, its descriptor in root request-provider composition, andwithRequestProvideron the Linux registration) and moves the provider vocabulary from@agent-device/contracts/linux-tool-providerintopackages/platform-linux/src/tool-provider-types.ts. The plugin's declared operations are now just thedoctortoolchain probe.Provider-backed integration drives the family through a fake
PlatformHostinstalled with the plugin's ownsetup. The real inventory, runtime, interactor and xdotool/xclip/scrot/AT-SPI tool selection are under test, and the scenario asserts the desktop argv the family produced. ADR 0001 carries a dated amendment.Part of #4878; the rest landed in #4948.
Value
@agent-device/contractspublished subpaths: 146 at base, 145 now.src/platform-runtime/request-providers.ts: 383 lines at base, 358 now.packages/platform-linux/src/tool-provider.ts: 289 at base, 258 now;interactor.ts: 104, 87 now.Validation
Head
195f72c1eeon0.22.pnpm test:unit: 2259 files green, 8 skipped.pnpm exec vitest run --project provider-integration: 83 files, 318 passed.check:layering,check:di-seams,check:production-exports,check:fallow,check:adr-citations,check:capabilities-matrix,check:gate-manifest,check:command-docs,test:integration:progress:check,check:daemon-wire-compat,lint,typecheck: pass.grep -rn linuxToolProvideris empty outside git history.Closes #4878