fix(think): preserve regeneration branch context - #2038
Open
ben-reitz wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: fcda26e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
ben-reitz
marked this pull request as ready for review
August 5, 2026 08:44
ben-reitz
marked this pull request as draft
August 5, 2026 13:03
ben-reitz
marked this pull request as ready for review
August 6, 2026 11:04
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
4 times, most recently
from
August 13, 2026 10:21
48e57e5 to
935bbb7
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 17, 2026 09:23
ce64aca to
593c5c2
Compare
This was referenced Aug 17, 2026
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 17, 2026 09:42
593c5c2 to
6228fd1
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 18, 2026 08:49
6228fd1 to
6783afe
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 18, 2026 09:17
6783afe to
53734cb
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 18, 2026 09:29
53734cb to
c5e0fc4
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 18, 2026 10:25
c5e0fc4 to
2ee21b6
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
3 times, most recently
from
August 18, 2026 13:17
dce349e to
8659e64
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 19, 2026 09:15
8659e64 to
fcda26e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2120.
Bug
Regeneration means “answer this user message again” while keeping the previous answer available. Think already stored the new answer as a sibling, but it generated that answer from the wrong history.
The result looked like a new branch in storage, but the model had been asked to continue the old answer instead of producing an independent alternative.
Fix
Think now uses one server-validated branch point for both model input and output storage. For regeneration, model history ends at the selected user message, and the generated answer is stored beneath that same message.
The selected history also remains the inference source when lifecycle hooks or context compaction prepare the turn.
Testing
Fixes #2028
Stack