fix(agents): keep session compactions branch-local - #2120
Merged
Conversation
🦋 Changeset detectedLatest commit: 0028a20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
ben-reitz
force-pushed
the
fix/session-branch-compaction
branch
2 times, most recently
from
August 18, 2026 08:49
92f8508 to
967bf6d
Compare
ben-reitz
force-pushed
the
fix/session-branch-compaction
branch
from
August 18, 2026 09:17
967bf6d to
0028a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Session compaction overlays* were selected globally before the provider checked whether their endpoint belonged to the requested conversation branch. A newer sibling-branch compaction could therefore hide a valid compaction for the branch being read.
SQLite compactions were also ordered only by
CURRENT_TIMESTAMP, whose one-second resolution made the winning overlay nondeterministic when multiple compactions were created together.Fix
created_at, rowidfor deterministic tiesTesting
Stack
This PR was getting too big so I've stacked a bunch of related fixes into separate PRs: