Skip to content

chore: New style api for popover, tooltip, copy-to-clipboard - #5175

Merged
pan-kot merged 4 commits into
mainfrom
chore-more-style-v2-components
Oct 29, 2026
Merged

pan-kot merged 4 commits into
mainfrom
chore-more-style-v2-components

Conversation

@pan-kot

@pan-kot pan-kot commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Description

New APIs are reflected in the tracker: P3d34KdbCd6o.

One difference to the existing components: Dropdown.dropdown was renamed to Dropdown.container - for consistency with new Popover and Tooltip APIs.

In Copy to clipboard we use a new approach: its style class names look as follows:

{
  copyButton?: string;
  statusPopover?: PopoverStyleAPI;
}

The status popover is referenced as a whole (container + arrow) - not as a single slot. This requires a small change to the docs-forwards util to allow slot be optional (cloudscape-design/component-toolkit#267). The existing components do not need to change, e.g. referencing a dismissButton to Button.root is sensible, and in the future we can support an extension if there is practical need:

{
  ...
  dismissButton?: string | ButtonStyleAPI;
}

How has this been tested?

Unit tests and test pages

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (396e7f1) to head (a18f1bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5175   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         998      998           
  Lines       32294    32299    +5     
  Branches    11945    11952    +7     
=======================================
+ Hits        31564    31569    +5     
  Misses        685      685           
  Partials       45       45           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot
pan-kot added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 28, 2026
@pan-kot
pan-kot added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 0bdb316 Oct 29, 2026
68 checks passed
@pan-kot
pan-kot deleted the chore-more-style-v2-components branch October 29, 2026 06:01

This branch was successfully deployed

3 active deployments
dev-pages-react18 — a18f1bc2 Deployed Oct 28, 2026 by pan-kot via deploy (React 18) / deploy #3030
dev-pages-react16 — a18f1bc2 Deployed Oct 28, 2026 by pan-kot via deploy (React 16) / deploy #3030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants