Skip to content

test: skip the ReplaceModelTest cases that SQLSRV's replace() cannot run - #10697

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:replace-model-sqlsrv-tests
Nov 1, 2026
Merged

test: skip the ReplaceModelTest cases that SQLSRV's replace() cannot run#10697
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:replace-model-sqlsrv-tests

Conversation

@paulbalandan

@paulbalandan paulbalandan commented Nov 1, 2026

Copy link
Copy Markdown
Member

Description
Three ReplaceModelTest cases added with the Model::replace() field protection fail on SQLSRV, because its replace() removes the existing row through a SELECT and DELETE keyed on the primary or unique fields, then runs SET IDENTITY_INSERT:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
paulbalandan requested a review from michalsn November 1, 2026 13:12
@carson-codeigniter4 carson-codeigniter4 Bot added the testing Pull requests that changes tests only label Nov 1, 2026
@paulbalandan
paulbalandan merged commit 6942f3a into codeigniter4:develop Nov 1, 2026
58 checks passed
@paulbalandan
paulbalandan deleted the replace-model-sqlsrv-tests branch November 1, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes
@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @michalsn @samsonasik