Skip to content

test: skip the ReplaceModelTest cases that SQLSRV's replace() cannot run #10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 1 commit into from
Nov 1, 2026
+12 −1
Merged

test: skip the ReplaceModelTest cases that SQLSRV's replace() cannot run #10697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/system/Models/ReplaceModelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ public function testReplaceProtectsFieldsWhenReturningSQL(): void

$this->assertIsString($sql);
$this->assertStringNotContainsString('description', $sql);
$this->seeInDatabase('job', ['id' => 1, 'name' => 'Developer']);

if ($this->db->DBDriver !== 'SQLSRV') {
$this->seeInDatabase('job', ['id' => 1, 'name' => 'Developer']);
}
}

public function testReplaceWithProtectionDisabled(): void
Expand Down Expand Up @@ -125,6 +128,10 @@ public function testReplaceWithoutAllowedFields(): void

public function testReplacePreservesCustomPrimaryKey(): void
{
if ($this->db->DBDriver === 'SQLSRV') {
$this->markTestSkipped('SQLSRV replace() requires an identity column.');
}

$model = $this->createModel(WithoutAutoIncrementModel::class);

$this->assertNotFalse($model->replace([
Expand Down Expand Up @@ -246,6 +253,10 @@ public static function provideReplaceWithEmptyDataUsesBuilderData(): iterable

public function testReplaceWithEmptyDataCanGenerateTimestamps(): void
{
if ($this->db->DBDriver === 'SQLSRV') {
$this->markTestSkipped('SQLSRV replace() deletes by key fields and rejects data without them.');
}

$model = $this->createModel(JobModel::class);
$this->setPrivateProperty($model, 'useTimestamps', true);

Expand Down
Loading