Repository navigation
feat(references): the references by modeling, each from its own solves (#435) - #474
Merged
Merged
Conversation
#435, T5 of #449) One table per modeling and scheme, [<modeling>.<scheme>], at the default grid of the problem in the modeling; reference_objective, solution_kind, references and best_reference take the backend (breaking). update.jl groups the solves by modeling; the problem pages show each modeling against its own reference and compute how close the modelings are. References regenerated from the crons 44015064560, 44235205662, 44455617205 and 42387115100: every former value is the one of a modeling, the others within 1.5e-6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #435, #449 (T5). Based on #473 (itself on #472): to merge after them. Conventions: ct-conventions v0.14.0, ct-agents v0.5.0.
Summary
The modelings are independent but for the definition of the problems (#435). A reference objective was shared by every modeling, computed from all their solves: a modeling that drifted moved the reference of the others, and a modeling with its own grid (ModelingToolkit, #473) had none. Now each modeling has its references.
ext/MetaData/references/<problem>.toml: one table per modeling and scheme,[JuMP.trapeze],[ModelingToolkit.shooting_single], at the default grid of the problem in the modeling (grid_size_data(problem, backend)), from the solves of that modeling only.reference_objective,solution_kind,references,best_referencetake the backend:reference_objective(:beam, OptimalControlBackend()). Defaults: the grid of the modeling, its discretization (:trapeze,:shooting_singlefor ModelingToolkit). CHANGELOG and BREAKING updated, guides updated.tools/references: grouped by modeling, then scheme; a table not recomputed (another modeling or scheme) is kept.:validwithout a reference; the comparison rule asks for a reference in one modeling at least.SAME_SOLUTION= 1e-5). The ModelingToolkit references come with the next cron, on its new grid.Test plan
core: 2326 passed (the reference tool tested on real modelings, each with its grid; the API by modeling over the collection).docs/preview.sh build: built;beampage checked.🤖 Generated with Claude Code