Skip to content

fix(dcql): resolve ldp_vc query filtering and json-ld serialization#421

Merged
sagarkhole4 merged 2 commits into
mainfrom
feat/JSONLD_JWTVC
Jul 3, 2026
Merged

fix(dcql): resolve ldp_vc query filtering and json-ld serialization#421
sagarkhole4 merged 2 commits into
mainfrom
feat/JSONLD_JWTVC

Conversation

@sagarkhole4

@sagarkhole4 sagarkhole4 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Fixed credential lookup for linked data proofs so the correct credential format is used.
    • Improved handling of optional fields in credentials and presentations, avoiding unexpected values when fields are omitted.
    • Prevented JSON-LD processing from trying to expand missing properties, reducing errors with incomplete data.

…rrors

Signed-off-by: Sagar Khole <sagar.khole@ayanworks.com>
@sagarkhole4 sagarkhole4 requested a review from sairanjit July 3, 2026 04:17
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@sagarkhole4, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 312381de-8055-469f-ae1f-add6ef91d3cc

📥 Commits

Reviewing files that changed from the base of the PR and between 3bbddfa and 660dd5a.

📒 Files selected for processing (2)
  • patches/@credo-ts+core+0.6.2+001-fix-change-version-string-type-import-esm-export-interface.patch
  • patches/@credo-ts+core+0.6.2+002-fix-export-defaultDocumentLoader.patch
📝 Walkthrough

Walkthrough

This PR adds two dependency patch files: one for @credo-ts/core adjusting DCQL credential format filtering, making W3cCredential/W3cPresentation constructors skip undefined optional fields, and exposing defaultDocumentLoader; another for @digitalcredentials/jsonld to skip expansion of undefined object properties.

Changes

Dependency Patches

Layer / File(s) Summary
DCQL format filter update
patches/@credo-ts+core+0.6.2+002+fix: export defaultDocumentLoader.patch
DcqlService now derives expandedTypes from credentials with format "ldp_vc" instead of "jwt_vc_json" for LdpVc claim format.
Conditional optional field assignment & exported loader type
patches/@credo-ts+core+0.6.2+002+fix: export defaultDocumentLoader.patch
W3cCredential and W3cPresentation constructors assign id/expirationDate only when defined; adds exported defaultDocumentLoader type declaration and package.json exports entry.
Skip undefined properties during JSON-LD expansion
patches/@digitalcredentials+jsonld+9.0.0.patch
expand.js's _expandObject loop skips keys whose value is undefined instead of processing them.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the two main fixes: DCQL filtering for ldp_vc and JSON-LD serialization/expansion behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/JSONLD_JWTVC

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sagarkhole4 sagarkhole4 self-assigned this Jul 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@patches/`@credo-ts+core+0.6.2+002+fix: export defaultDocumentLoader.patch:
- Line 1: The patch file name uses invalid Windows characters in its description
segment, so rename the patch to follow patch-package’s convention without spaces
or a colon. Update the filename for the `@credo-ts/core` patch so it uses hyphens
only, and ensure any references to the patch name in tooling or docs match the
new sanitized name.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b8723cb-1b33-4dff-86ff-40def249dc49

📥 Commits

Reviewing files that changed from the base of the PR and between 95b21c2 and 3bbddfa.

📒 Files selected for processing (2)
  • patches/@credo-ts+core+0.6.2+002+fix: export defaultDocumentLoader.patch
  • patches/@digitalcredentials+jsonld+9.0.0.patch

…rrors

Signed-off-by: Sagar Khole <sagar.khole@ayanworks.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@sagarkhole4 sagarkhole4 merged commit 3f9d90e into main Jul 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants