Repository navigation
fix: show port numbers without a thousands separator - #455
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
In the sidebar, a workspace listening on port 3000 showed
:3.000(or:3,000, depending on your region settings). The stop-port dialog had the same problem: "Stop node on port 3.000?", and process IDs in it read like "12.345". Ports and process IDs now always show as plain digits.Summary
IntintoString(localized:)formats it with the user's locale, so%lldpicks up grouping separators.Text(verbatim:), matchingPortsHubView, and its string entry is gone, since a port number has nothing to translate.String(port)/String(pid), and their en/ja entries switch from%lldto%@.No regression test: what's wrong here is the rendered SwiftUI text under a non-English locale. The repo's test policy rules out tests that assert on string-catalog contents, and no runtime seam reads the rendered label.
Test Plan
python3 -m http.server 3000in a workspace: the sidebar shows:3000.